[asterisk-bugs] [Asterisk 0018042]: [patch] inefficient strlen() in ast_uri_decode loop

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18042 
====================================================================== 
Reported By:                wdoekes
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18042
Category:                   General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 288635 
Request Review:              
====================================================================== 
Date Submitted:             2010-09-23 15:29 CDT
Last Modified:              2011-01-19 13:02 CST
====================================================================== 
Summary:                    [patch] inefficient strlen() in ast_uri_decode loop
Description: 
Hi,

ast_uri_decode features a loop in which for every '%' encountered strlen()
is called. This is suboptimal.

Regards,
Walter
====================================================================== 

---------------------------------------------------------------------- 
 (0130719) svnbot (reporter) - 2011-01-19 13:02
 https://issues.asterisk.org/view.php?id=18042#c130719 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 302554

U   branches/1.6.2/main/utils.c

------------------------------------------------------------------------
r302554 | seanbright | 2011-01-19 13:02:30 -0600 (Wed, 19 Jan 2011) | 7
lines

Don't call strlen() when we only need to look at the next character or
two.

(closes issue https://issues.asterisk.org/view.php?id=18042)
Reported by: wdoekes
Patches:
      astsvn-inefficient-ast-uri-decode.patch uploaded by wdoekes (license
717)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=302554 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-19 13:02 svnbot         Checkin                                      
2011-01-19 13:02 svnbot         Note Added: 0130719                          
======================================================================