[asterisk-bugs] [Asterisk 0016135]: [patch] ast_gethostbyname doesn't set h_length if argument is an IP Address

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16135 
====================================================================== 
Reported By:                thedavidfactor
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16135
Category:                   Core/Netsock
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-10-26 17:08 CDT
Last Modified:              2011-01-19 11:42 CST
====================================================================== 
Summary:                    [patch] ast_gethostbyname doesn't set h_length if
argument is an IP Address
Description: 
If an IP Address is give as the argument to ast_gethostbyname it
short-circuits and returns the ast_hostent with the provided IP Address,
however it doesn't set the h_length attribute, as it does if the argument
is a hostname. This was discussed with ebroad & mvanbaak on #asterisk-dev
====================================================================== 

---------------------------------------------------------------------- 
 (0130708) seanbright (manager) - 2011-01-19 11:42
 https://issues.asterisk.org/view.php?id=16135#c130708 
---------------------------------------------------------------------- 
I think the only reason this works is because h_addr is a char * which is 4
on 32 bit systems.  An IPv4 address will always be 4 bytes, regardless of
bitness.  So the patch I am applying just hard codes this fact. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-19 11:42 seanbright     Note Added: 0130708                          
======================================================================