[asterisk-bugs] [Asterisk 0018640]: [patch] Potential malfunction due to unitialized local variable

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18640 
====================================================================== 
Reported By:                jcovert
Assigned To:                seanbright
====================================================================== 
Project:                    Asterisk
Issue ID:                   18640
Category:                   Channels/chan_sip/General
Reproducibility:            random
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!): 302314 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-01-18 19:39 CST
Last Modified:              2011-01-19 09:46 CST
====================================================================== 
Summary:                    [patch] Potential malfunction due to unitialized
local variable
Description: 
The compiler correctly reports:

In function 'parse_register_contact':
'single_binding_found' may be used uninitialized

Upon inspection, if (!strcasecmp(curi, "*")) we will set wildcard = 1 and
single_binding_found will have a random value, since initialization of
local variables is undefined.

At the next line:

if (wildcard_found && (ast_strlen_zero(expires) || expire != 0 ||
single_binding_found))

we now test single binding found in an "or", and the result will be
random.

A patch to 1.8 head is provided.
====================================================================== 

---------------------------------------------------------------------- 
 (0130680) svnbot (reporter) - 2011-01-19 09:46
 https://issues.asterisk.org/view.php?id=18640#c130680 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 302415

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r302415 | seanbright | 2011-01-19 09:46:57 -0600 (Wed, 19 Jan 2011) | 14
lines

Merged revisions 302414 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r302414 | seanbright | 2011-01-19 10:45:17 -0500 (Wed, 19 Jan 2011) | 7
lines
  
  Initialize an uninitialized variable.
  
  (closes issue https://issues.asterisk.org/view.php?id=18640)
  Reported by: jcovert
  Patches:
        chan_sip.c.patch uploaded by jcovert (license 551)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=302415 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-19 09:46 svnbot         Checkin                                      
2011-01-19 09:46 svnbot         Note Added: 0130680                          
======================================================================