[asterisk-bugs] [Asterisk 0018640]: Potential malfunction due to unitialized local variable

[Asterisk Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18640 
====================================================================== 
Reported By:                jcovert
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18640
Category:                   Channels/chan_sip/General
Reproducibility:            random
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!): 302314 
Request Review:              
====================================================================== 
Date Submitted:             2011-01-18 19:39 CST
Last Modified:              2011-01-18 19:39 CST
====================================================================== 
Summary:                    Potential malfunction due to unitialized local
variable
Description: 
The compiler correctly reports:

In function 'parse_register_contact':
'single_binding_found' may be used uninitialized

Upon inspection, if (!strcasecmp(curi, "*")) we will set wildcard = 1 and
single_binding_found will have a random value, since initialization of
local variables is undefined.

At the next line:

if (wildcard_found && (ast_strlen_zero(expires) || expire != 0 ||
single_binding_found))

we now test single binding found in an "or", and the result will be
random.

A patch to 1.8 head is provided.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-18 19:39 jcovert        New Issue                                    
2011-01-18 19:39 jcovert        Asterisk Version          => SVN             
2011-01-18 19:39 jcovert        Regression                => No              
2011-01-18 19:39 jcovert        SVN Branch (only for SVN checkouts, not tarball
releases) => 1.8             
2011-01-18 19:39 jcovert        SVN Revision (number only!) => 302314          
======================================================================