[asterisk-bugs] [Asterisk 0018310]: [patch] hint state changes deadlock/race

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18310 
====================================================================== 
Reported By:                one47
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   18310
Category:                   Core/PBX
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.2.17
Asterisk Version:           1.6.2.14 
JIRA:                       SWP-2541 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1072 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-15 12:19 CST
Last Modified:              2011-01-18 03:30 CST
====================================================================== 
Summary:                    [patch] hint state changes deadlock/race
Description: 
VERY similar to https://issues.asterisk.org/view.php?id=18165, but this is a
different deadlock path, so I have
raised a separate report.

Thread 1: taskprocessor  -> handle_statechange
    Lock order = conlock, hints, hint, pvt
Thread 2: chan_sip.c:  handle_request_do -> handle_response_notify
    Lock order = pvt, conlock

Thread2 only gets into the conlock if STATECHANGEQUEUE is true, ie. there
are rapid state changes happening on a subscribed hint.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018165 [patch] hint state changes deadlock pro...
has duplicate       0018535 app_queue deadlocks if weight is set
====================================================================== 

---------------------------------------------------------------------- 
 (0130585) MKemner (reporter) - 2011-01-18 03:30
 https://issues.asterisk.org/view.php?id=18310#c130585 
---------------------------------------------------------------------- 
the statecbs_ao2.mk2.patch does not work on 1.8.2 - although it patches
(all hunks succeeded, at various offsets) at compile time I get:

pbx.c: In function 'hints_data_provider_get':
pbx.c:9844: error: request for member 'first' in something not a structure
or union

line 9844 being AST_LIST_TRAVERSE(&hint->callbacks, watcher, entry)

I know the patch is for 1.6 not 1.8 but just wanted to give some feedback
- this same bug exists in 1.8 so as loloski said it would be nice to have a
fix there too :) - am using the deadlock_backoff.patch for now. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-18 03:30 MKemner        Note Added: 0130585                          
======================================================================