[asterisk-bugs] [DAHDI-linux 0018604]: [patch] fails to compile against kernel 2.6.37 without CONFIG_BKL

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18604 
====================================================================== 
Reported By:                jkroon
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   18604
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     acknowledged
JIRA:                       DAHDI-752 
Reviewboard Link:            
====================================================================== 
Date Submitted:             2011-01-12 07:28 CST
Last Modified:              2011-01-12 15:05 CST
====================================================================== 
Summary:                    [patch] fails to compile against kernel 2.6.37
without CONFIG_BKL
Description: 
dahdi-linux refuses to compile against the 2.6.37 kernel unless CONFIG_BKL
is set.  CONFIG_BKL is set to die very soon.
====================================================================== 

---------------------------------------------------------------------- 
 (0130430) sruffell (administrator) - 2011-01-12 15:05
 https://issues.asterisk.org/view.php?id=18604#c130430 
---------------------------------------------------------------------- 
First, regarding the mutexes and semaphores.  I believe those issues are
all resolved in the current trunk:

http://svn.asterisk.org/view/dahdi?view=revision&revision=9464
http://svn.asterisk.org/view/dahdi?view=revision&revision=9579

You should prepare your patches against the current trunk if you are not
already

Second, you do not need to clone any particular git repo if you don't want
to.  You can:

git svn clone -r HEAD http://svn.asterisk.org/dahdi/linux/trunk for-dahdi

then in for-dahdi, make your edits, and get the commit(s) looking like you
want, then 

]# git format-patch git-svn..HEAD

to make the patches that you want to attach to this issue.

However, I currently keep https://github.com/sruffell/dahdi-linux updated
if you want to clone that, but it's nothing official.

Third, CONFIG_BKL is the default since it's pulled in from
lib/Kconfig.debug.  If you run "make defconfig" in your kernel tree and
then look at your .config file, you'll see CONFIG_BKL is defined.

Fourth, it's the "unlocked" patch I think we want here, not the locked
patch.  And for the dialparams it's not in the hotpath so the most general
think to use is a mutex, unless there really aren't any allocations or
anything in the code path, in which case I would use a spinlock.

Finally, I didn't see what you were referring to as the mess with the
function declarations in you unlocked ioctl patch.  It looked good to me
(again with the exception that it should still call lock_kernel if
CONFIG_BKL is defined, and add some protection for the global dial params). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-12 15:05 sruffell       Note Added: 0130430                          
======================================================================