[asterisk-bugs] [DAHDI-linux 0018604]: [patch] fails to compile against kernel 2.6.37 without CONFIG_BKL

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18604 
====================================================================== 
Reported By:                jkroon
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   18604
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     acknowledged
JIRA:                       DAHDI-752 
Reviewboard Link:            
====================================================================== 
Date Submitted:             2011-01-12 07:28 CST
Last Modified:              2011-01-12 14:15 CST
====================================================================== 
Summary:                    [patch] fails to compile against kernel 2.6.37
without CONFIG_BKL
Description: 
dahdi-linux refuses to compile against the 2.6.37 kernel unless CONFIG_BKL
is set.  CONFIG_BKL is set to die very soon.
====================================================================== 

---------------------------------------------------------------------- 
 (0130428) jkroon (reporter) - 2011-01-12 14:15
 https://issues.asterisk.org/view.php?id=18604#c130428 
---------------------------------------------------------------------- 
Which tree do you want me to clone?

You'll note I also cleaned up the mess with regards to the function
declaration - is this change OK with you?  (IE, can I keep this change in
the new patch)

CONFIG_BKL is as far as I can tell already not the default anymore since
at least 2.6.37 (check both configs in arch/x86/configs, neither of which
has CONFIG_BKL set).

Essentially it sounds like you want the -locked variant of the patch
though which just replaces the BKL with a local mutex which should achieve
the same thing as using the BKL, except that it has a local effect only
instead of locking the entire kernel.

Ok, protecting the global_dialparams doesn't look too difficult, rwlock or
a simple spinlock?  I read somewhere today that rwlocks are being
deprecated - what's the replacement anyway?

I've also found some issues with respect to the "mutexes" used in some of
the other modules, eg, voicebus, attaching a patch.  If you're OK with the
actual changes I'll roll a version that has any required #ifdef protection
for that too.  It would seem previously the mutexes was just aliases for
semaphores anyway, so I just went to using the semaphore functions
directly.  I think there may be issues with DEFINE_SEMAPHORE vs
DECLARE_SEMAPHORE though but I'm not sure, which is why the offer to roll a
new patch on this too that takes that into consideration.

The struct mutex code I used in my -locked patch is at least available on
2.6.36 - if someone can indicate to me at which kernel version that became
available that would be useful information too. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-12 14:15 jkroon         Note Added: 0130428                          
======================================================================