[asterisk-bugs] [Asterisk 0018606]: [patch] unopenable spool files not deleted

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18606 
====================================================================== 
Reported By:                chappell
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18606
Category:                   PBX/pbx_spool
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.8.1.1 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-01-12 09:48 CST
Last Modified:              2011-01-12 09:54 CST
====================================================================== 
Summary:                    [patch] unopenable spool files not deleted
Description: 
If scan_service() cannot open the spool file, it logs a message saying that
it will delete the file and calls remove_from_queue() to do it. However,
remove_from_queue() fails to delete the spool file because struct outgoing
has not yet been fully initialized.

I have attached a patch which fixes this by calling unlink() instead of
remove_from_queue().

(The patch makes two other minor changes: 1) fixes a garbled comment and
2) moves a log messages so that it actually comes before the operation
which it says is about to be performed.)

I am not sure that my patch represents the best way to fix this. For
example, it might be better to fill in o->fn earlier so that an attempt can
be mode to move the unopenable spool file into the archive directory.

====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-12 09:54 lmadsen        Status                   new => ready for
testing
======================================================================