[asterisk-bugs] [Asterisk 0018046]: [patch] func_curl CURLOPT likes a querycomponent (+-decoding) hashcompat mode

Asterisk Bug Tracker noreply at bugs.digium.com
Thu Jan 6 10:09:52 UTC 2011


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18046 
====================================================================== 
Reported By:                wdoekes
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18046
Category:                   Functions/func_curl
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.8.0-rc2 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-09-24 04:16 CDT
Last Modified:              2011-01-06 04:09 CST
====================================================================== 
Summary:                    [patch] func_curl CURLOPT likes a querycomponent
(+-decoding) hashcompat mode
Description: 
Hi,

in https://issues.asterisk.org/view.php?id=18037 I've added a QSFIELD
which is pretty much obsoleted by the hashcompat mode of CURLOPT.

However, the ast_uri_decode leaves +'es verbatim in the decoded output,
where I expect them to be decoded to spaces.

The attached patch adds a hashcompat=querycomponent mode that decodes the
pluses properly. (For backwards compatibility the ast_value() works for all
other values.)

Regards,
Walter Doekes
OSSO B.V.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
child of            0018037 [patch] func_uri could use a QSFIELD fu...
====================================================================== 

---------------------------------------------------------------------- 
 (0130246) wdoekes (reporter) - 2011-01-06 04:09
 https://issues.asterisk.org/view.php?id=18046#c130246 
---------------------------------------------------------------------- 
(Oh, and I believe you also missed a ast_calloc before new->value = ...)

Here is an updated patch for 1.6.2.15 -- issue 18161 has been fixed --
without your socks-edits and with my two comments. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-06 04:09 wdoekes        Note Added: 0130246                          
======================================================================




More information about the asterisk-bugs mailing list