[asterisk-bugs] [Asterisk 0018561]: [patch] p->owner unregistered from module prematurely in local_hangup.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18561 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18561
Category:                   Channels/chan_local
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-2832 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 292867 
Request Review:              
====================================================================== 
Date Submitted:             2010-12-30 11:09 CST
Last Modified:              2011-01-05 09:00 CST
====================================================================== 
Summary:                    [patch] p->owner unregistered from module
prematurely in local_hangup.
Description: 
r 259899 introduces deadlock avoidance for p->owner.  This is done after
p->owner is unregistered from the module. The equivalent code for p->chan
does the unregister immediately adjacent to the nulling, when all the locks
have been obtained.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018558 [patch] p->chan can disappear betwee...
related to          0017185 [patch] [regression] Using Local channe...
====================================================================== 

---------------------------------------------------------------------- 
 (0130198) davidw (reporter) - 2011-01-05 09:00
 https://issues.asterisk.org/view.php?id=18561#c130198 
---------------------------------------------------------------------- 
I've uploaded a patch which moves the module_user_remove to a safer place.

This patch overlaps with the patch for
https://issues.asterisk.org/view.php?id=18558, but I've created it as
though that had not been applied.  If you do try to apply both, you will
get a match with fuzz, if you apply this second.  If you apply it first,
there may be fuzz, or it might not take.

Note, I don't like the idea of removing the reference counts within the
referenced module, but we don't unload it, except at shutdown. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-05 09:00 davidw         Note Added: 0130198                          
======================================================================