[asterisk-bugs] [Asterisk 0018075]: [patch] Asterisk fails to recognize SUBSCRIBE retransmissions and tries to re-authenticate them, which breaks presence on polyco

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18075 
====================================================================== 
Reported By:                mdu113
Assigned To:                twilson
====================================================================== 
Project:                    Asterisk
Issue ID:                   18075
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-2327 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1005/ 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 289177 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-09-29 16:16 CDT
Last Modified:              2011-01-04 12:06 CST
====================================================================== 
Summary:                    [patch] Asterisk fails to recognize SUBSCRIBE
retransmissions and tries to re-authenticate them, which breaks presence on
polyco
Description: 
Here's what happens from asterisk point of view:
-> SUBSCRIBE
<- 401 Unauthorized
-> SUBSCRIBE with auth
<- 200 OK (lost)
<- NOTIFY
-> 200 OK for NOTIFY
-> SUBSCRIBE with auth retransmission
<- 401 Unauthorized
At this point polycom phone received 2 "401 Unauthorized" in a row and it
completely gives up on resubscribing to this hint until reboot. While
polycom behavior is questionable, I believe asterisk should recognize
retransmission and resubmit 200OK in this case
====================================================================== 

---------------------------------------------------------------------- 
 (0130140) svnbot (reporter) - 2011-01-04 12:06
 https://issues.asterisk.org/view.php?id=18075#c130140 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 300302

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r300302 | twilson | 2011-01-04 12:06:47 -0600 (Tue, 04 Jan 2011) | 36
lines

Merged revisions 300301 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r300301 | twilson | 2011-01-04 11:54:41 -0600 (Tue, 04 Jan 2011) | 29
lines
  
  Merged revisions 300298 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2
  
  ................
    r300298 | twilson | 2011-01-04 11:37:26 -0600 (Tue, 04 Jan 2011) | 22
lines
    
    Merged revisions 300216 via svnmerge from 
    https://origsvn.digium.com/svn/asterisk/branches/1.4
    
    ........
      r300216 | twilson | 2011-01-04 11:11:48 -0600 (Tue, 04 Jan 2011) |
15 lines
      
      Don't authenticate SUBSCRIBE re-transmissions
      
      This only skips authentication on retransmissions that are already
      authenticated. A similar method is already used for INVITES. This
      is the kind of thing we end up having to do when we don't have a
      transaction layer...
      
      (closes issue https://issues.asterisk.org/view.php?id=18075)
      Reported by: mdu113
      Patches: 
            diff.txt uploaded by twilson (license 396)
      Tested by: twilson, mdu113
      
      Review: https://reviewboard.asterisk.org/r/1005/
    ........
  ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=300302 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-04 12:06 svnbot         Checkin                                      
2011-01-04 12:06 svnbot         Note Added: 0130140                          
======================================================================