[asterisk-bugs] [Asterisk 0018075]: [patch] Asterisk fails to recognize SUBSCRIBE retransmissions and tries to re-authenticate them, which breaks presence on polyco

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18075 
====================================================================== 
Reported By:                mdu113
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18075
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-2327 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1005/ 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 289177 
Request Review:              
====================================================================== 
Date Submitted:             2010-09-29 16:16 CDT
Last Modified:              2011-01-04 11:11 CST
====================================================================== 
Summary:                    [patch] Asterisk fails to recognize SUBSCRIBE
retransmissions and tries to re-authenticate them, which breaks presence on
polyco
Description: 
Here's what happens from asterisk point of view:
-> SUBSCRIBE
<- 401 Unauthorized
-> SUBSCRIBE with auth
<- 200 OK (lost)
<- NOTIFY
-> 200 OK for NOTIFY
-> SUBSCRIBE with auth retransmission
<- 401 Unauthorized
At this point polycom phone received 2 "401 Unauthorized" in a row and it
completely gives up on resubscribing to this hint until reboot. While
polycom behavior is questionable, I believe asterisk should recognize
retransmission and resubmit 200OK in this case
====================================================================== 

---------------------------------------------------------------------- 
 (0130135) svnbot (reporter) - 2011-01-04 11:11
 https://issues.asterisk.org/view.php?id=18075#c130135 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 300216

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r300216 | twilson | 2011-01-04 11:11:49 -0600 (Tue, 04 Jan 2011) | 15
lines

Don't authenticate SUBSCRIBE re-transmissions

This only skips authentication on retransmissions that are already
authenticated. A similar method is already used for INVITES. This
is the kind of thing we end up having to do when we don't have a
transaction layer...

(closes issue https://issues.asterisk.org/view.php?id=18075)
Reported by: mdu113
Patches: 
      diff.txt uploaded by twilson (license 396)
Tested by: twilson, mdu113

Review: https://reviewboard.asterisk.org/r/1005/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=300216 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-04 11:11 svnbot         Checkin                                      
2011-01-04 11:11 svnbot         Note Added: 0130135                          
======================================================================