[asterisk-bugs] [DAHDI-linux 0013205]: [patch] bad master selection

Asterisk Bug Tracker noreply at bugs.digium.com
Mon Jan 3 18:26:11 UTC 2011


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=13205 
====================================================================== 
Reported By:                biohumanoid
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13205
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2008-07-31 00:11 CDT
Last Modified:              2011-01-03 12:26 CST
====================================================================== 
Summary:                    [patch] bad master selection
Description: 
Current dahdi master handling work in the following way:
The first SPAN become a master
If a new registered !!! SPAN is preferred , it is the new master
If a span is unregistered - the new master is the first available span
If master SPAN is in alarm state - the new master is the first non in
alarm state SPAN

So
1. dahdi-dummy once loaded will be the master forever.
2. even not-running SPAN can be a master
3. master implementation is ugly...
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013206 [patch] ztdynamic double buffering on r...
====================================================================== 

---------------------------------------------------------------------- 
 (0130098) svnbot (reporter) - 2011-01-03 12:26
 https://issues.asterisk.org/view.php?id=13205#c130098 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 9581

U   linux/trunk/drivers/dahdi/dahdi-base.c
U   linux/trunk/drivers/dahdi/dahdi_dynamic_loc.c
U   linux/trunk/include/dahdi/kernel.h

------------------------------------------------------------------------
r9581 | sruffell | 2011-01-03 12:26:09 -0600 (Mon, 03 Jan 2011) | 18 lines

dahdi: Allow spans to advertise if they can provide any timing.

Some spans, specifically dynamic local spans, should never be the timing
master since they are dependent on some other timing source driving
them.

The bit in 'struct dahdi_span' is named cannot provide timing so that by
default the other drivers will set it to 0.

This is loosely related to issue https://issues.asterisk.org/view.php?id=13205
but doesn't address any of the
other elements of that issue about how to allow the user to configure
what the master span order of succession is.

(issue https://issues.asterisk.org/view.php?id=13205)
Reported by: biohumanoid

Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Kinsey Moore <kmoore at digium.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9581 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-03 12:26 svnbot         Note Added: 0130098                          
======================================================================




More information about the asterisk-bugs mailing list