[asterisk-bugs] [DAHDI-linux 0013205]: [patch] bad master selection

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=13205 
====================================================================== 
Reported By:                biohumanoid
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13205
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2008-07-31 00:11 CDT
Last Modified:              2011-01-03 12:25 CST
====================================================================== 
Summary:                    [patch] bad master selection
Description: 
Current dahdi master handling work in the following way:
The first SPAN become a master
If a new registered !!! SPAN is preferred , it is the new master
If a span is unregistered - the new master is the first available span
If master SPAN is in alarm state - the new master is the first non in
alarm state SPAN

So
1. dahdi-dummy once loaded will be the master forever.
2. even not-running SPAN can be a master
3. master implementation is ugly...
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013206 [patch] ztdynamic double buffering on r...
====================================================================== 

---------------------------------------------------------------------- 
 (0130097) svnbot (reporter) - 2011-01-03 12:25
 https://issues.asterisk.org/view.php?id=13205#c130097 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 9576

U   linux/trunk/drivers/dahdi/dahdi-base.c
U   linux/trunk/drivers/dahdi/dahdi_dynamic.c

------------------------------------------------------------------------
r9576 | sruffell | 2011-01-03 12:25:46 -0600 (Mon, 03 Jan 2011) | 16 lines

dahdi_dynamic: Use dahdi_span_ops.sync_tick for driving dynamic spans.

Dynamic spans that are unable to provide their own timing, like dahdi
local spans, typically derived their timing source from
dahdi_dynamic_ioctl(0,0) call in process_masterspan.

This change uses the sync_tick member of dahdi_span_ops instead so that
dynamic operations do not happen on a span until it is fully registered.
Also removes the check for dahdi_dynamic_ioctl in process masterspan for
those users that never load a dynamic span.

This was originally suggested in a comment on:
(issue https://issues.asterisk.org/view.php?id=13205)

Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Kinsey Moore <kmoore at digium.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9576 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-03 12:25 svnbot         Checkin                                      
2011-01-03 12:25 svnbot         Note Added: 0130097                          
======================================================================