[asterisk-bugs] [Asterisk 0018874]: [patch] sig_pri_new_ast_channel should return NULL when new_ast_channel fails to create a channel

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18874 
====================================================================== 
Reported By:                cmaj
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18874
Category:                   Channels/chan_dahdi
Reproducibility:            random
Severity:                   crash
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.8.3-rc2 
JIRA:                       SWP-3172 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-02-23 11:37 CST
Last Modified:              2011-02-23 17:38 CST
====================================================================== 
Summary:                    [patch] sig_pri_new_ast_channel should return NULL
when new_ast_channel fails to create a channel
Description: 
It appears that a non-existent channel's transfercapability was trying to
be set. This was during a kill -9 on a runaway box deadlocking in the TCP
TLS layer (which took over a minute to die, a separate matter.) But it
still looks like a bug. Patch attached.

(gdb) bt
https://issues.asterisk.org/view.php?id=0  sig_pri_new_ast_channel (p=0x12a0900,
state=<value optimized out>,
ulaw=<value optimized out>, transfercapability=16, exten=<value optimized
out>,
    requestor=<value optimized out>) at sig_pri.c:877
https://issues.asterisk.org/view.php?id=1  0x00007f7f5a2c95dc in pri_dchannel
(vpri=<value optimized out>) at
sig_pri.c:4951
https://issues.asterisk.org/view.php?id=2  0x000000000053707c in dummy_start
(data=<value optimized out>) at
utils.c:971
https://issues.asterisk.org/view.php?id=3  0x00007f7f652c3fc7 in start_thread ()
from /lib/libpthread.so.0
https://issues.asterisk.org/view.php?id=4  0x00007f7f65b0864d in clone () from
/lib/libc.so.6
https://issues.asterisk.org/view.php?id=5  0x0000000000000000 in ?? ()


====================================================================== 

---------------------------------------------------------------------- 
 (0132320) svnbot (reporter) - 2011-02-23 17:38
 https://issues.asterisk.org/view.php?id=18874#c132320 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 308622

U   branches/1.8/channels/sig_pri.c

------------------------------------------------------------------------
r308622 | rmudgett | 2011-02-23 17:38:05 -0600 (Wed, 23 Feb 2011) | 9
lines

sig_pri_new_ast_channel() should return NULL when new_ast_channel() fails.

(closes issue https://issues.asterisk.org/view.php?id=18874)
Reported by: cmaj
Patches:
      patch-sig_pri-crash-possible-null-channel-pointer.diff.txt uploaded
by cmaj (license 830)

JIRA SWP-3172

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=308622 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-23 17:38 svnbot         Checkin                                      
2011-02-23 17:38 svnbot         Note Added: 0132320                          
======================================================================