[asterisk-bugs] [Asterisk 0018862]: Free parking slot logic broken if randomising start - stops early and doesn't recognize it failed (#16428 is not complete fix)

[Asterisk Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18862 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18862
Category:                   Features/Parking
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 307231 
Request Review:              
====================================================================== 
Date Submitted:             2011-02-21 12:52 CST
Last Modified:              2011-02-21 12:52 CST
====================================================================== 
Summary:                    Free parking slot logic broken if randomising start 
- stops early and doesn't recognize it failed
(https://issues.asterisk.org/view.php?id=16428 is not complete fix)
Description: 
https://issues.asterisk.org/view.php?id=16428 fixes a bug relating to the exit
conditions for the free parking
slot search, but only does so if the start of the search is not randomised
(R option on ParkAndAnnounce()).

It stops the search when it hits the end of the range, not when it has
wrapped back to the starting point.

The subsequent code only properly handles the no free slot case when it
stops after going right round.  I haven't followed through, but I think
there is a potential crash downstream.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-21 12:52 davidw         New Issue                                    
2011-02-21 12:52 davidw         Asterisk Version          => SVN             
2011-02-21 12:52 davidw         Regression                => No              
2011-02-21 12:52 davidw         SVN Branch (only for SVN checkouts, not tarball
releases) =>  trunk          
2011-02-21 12:52 davidw         SVN Revision (number only!) => 307231          
======================================================================