[asterisk-bugs] [Asterisk 0018817]: MONITOR_FILENAME should be MIXMONITOR_FILENAME in documentation of MONITOR_EXEC

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18817 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18817
Category:                   Documentation
Reproducibility:            N/A
Severity:                   text
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 307791 
Request Review:              
====================================================================== 
Date Submitted:             2011-02-15 11:23 CST
Last Modified:              2011-02-18 10:25 CST
====================================================================== 
Summary:                    MONITOR_FILENAME should be MIXMONITOR_FILENAME in
documentation of MONITOR_EXEC
Description: 
In queues.conf.sample, both the variable used to force the filename for
MixMonitor and the variable that gets set to the actual filename are shown
as MONITOR_FILENAME.  However, the latter is actually MIXMONITOR_FILENAME,
as set by this line in app_mixmonitor.c:

apps/app_mixmonitor.c:  pbx_builtin_setvar_helper(chan,
"MIXMONITOR_FILENAME", args.filename);

and as indicated in the API meta-data:

                                <variable name="MIXMONITOR_FILENAME">
                                        <para>Will contain the filename
used to record.</para>
                                </variable>

====================================================================== 

---------------------------------------------------------------------- 
 (0132146) davidw (reporter) - 2011-02-18 10:25
 https://issues.asterisk.org/view.php?id=18817#c132146 
---------------------------------------------------------------------- 
MIXMONITOR_FILENAME *is* set before the variable substitution is performed
on the post processing command.  I re-instate my full original bug report.

.....
        pbx_builtin_setvar_helper(chan, "MIXMONITOR_FILENAME",
args.filename);
        launch_monitor_thread(chan, args.filename, flags.flags, readvol,
writevol, args.post_process);
.....

static void launch_monitor_thread(struct ast_channel *chan, const char
*filename
, unsigned int flags,

.....

        postprocess2[0] = 0;
        /* If a post process system command is given attach it to the
structure */
        if (!ast_strlen_zero(post_process)) {
                char *p1, *p2;

                p1 = ast_strdupa(post_process);
                for (p2 = p1; *p2 ; p2++) {
                        if (*p2 == '^' && *(p2+1) == '{') {
                                *p2 = '$';
                        }
                }
                pbx_substitute_variables_helper(chan, p1, postprocess2,
sizeof(postprocess2) - 1);
......
        ast_pthread_create_detached_background(&thread, NULL,
mixmonitor_thread, mixmonitor);
} 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-18 10:25 davidw         Note Added: 0132146                          
======================================================================