[asterisk-bugs] [Asterisk 0018747]: [regression] changeset 298596 harm the ring/moh logic in queues

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18747 
====================================================================== 
Reported By:                vrban
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   18747
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     closed
Target Version:             1.8.3
Asterisk Version:           1.4.40-rc2 
JIRA:                       SWP-3046 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-02-04 05:28 CST
Last Modified:              2011-02-15 17:34 CST
====================================================================== 
Summary:                    [regression] changeset 298596 harm the ring/moh 
logic in queues
Description: 
changeset 298596 (Fix improper hangup when doing an attended transfer to
queue)
changes the queue behavior. It ring instead of playing MOH. Or worse, it
play both, ring and Moh. e.g. one Agent phone ring, the caller get ring.
when the caller get refused by pressing DND, it get again Moh, so the
caller know, he was refused.

I dont think this behavioral change is willfully. as it completely the
ring/moh 
logic in the queue application.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0018733 [regression] When caller sent to queue,...
has duplicate       0018517 When caller sent to queue, MoH plays fo...
====================================================================== 

---------------------------------------------------------------------- 
 (0131995) svnbot (reporter) - 2011-02-15 17:34
 https://issues.asterisk.org/view.php?id=18747#c131995 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 308013

_U  trunk/
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r308013 | qwell | 2011-02-15 17:34:28 -0600 (Tue, 15 Feb 2011) | 31 lines

Merged revisions 308010 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r308010 | qwell | 2011-02-15 17:34:03 -0600 (Tue, 15 Feb 2011) | 24
lines
  
  Merged revisions 308007 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2
  
  ................
    r308007 | qwell | 2011-02-15 17:33:24 -0600 (Tue, 15 Feb 2011) | 17
lines
    
    Merged revisions 308002 via svnmerge from 
    https://origsvn.digium.com/svn/asterisk/branches/1.4
    
    ........
      r308002 | qwell | 2011-02-15 17:32:20 -0600 (Tue, 15 Feb 2011) | 10
lines
      
      Fix regression that changed behavior of queues when ringing a queue
member.
      
      This reverts r298596, which was to fix a highly bizarre and
contrived issue
      with a queue member that called into his own queue being transferred
back
      into his own queue.  I couldn't reproduce that issue in any way.  I
think one
      of the other recent transfer fixes actually fixed this.
      
      (closes issue https://issues.asterisk.org/view.php?id=18747)
      Reported by: vrban
    ........
  ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=308013 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-15 17:34 svnbot         Checkin                                      
2011-02-15 17:34 svnbot         Note Added: 0131995                          
======================================================================