[asterisk-bugs] [Asterisk 0018729]: [patch] [regression] Dial() and Queue() with a macro argument are broken by AEL macro compilation change

Mon Feb 14 00:54:09 CST 2011

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18729 
====================================================================== 
Reported By:                kkm
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   18729
Category:                   PBX/pbx_ael
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.3-rc2 
JIRA:                       SWP-3052 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-02-02 04:15 CST
Last Modified:              2011-02-14 00:54 CST
====================================================================== 
Summary:                    [patch] [regression] Dial() and Queue() with a macro
argument are broken by AEL macro compilation change
Description: 
Macros used to compile using 's' as the entry point, and that changed to
'~~s~~'. The change broke the macro argument to Dial and Queue
applications.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018480 [patch] Contexts with a 'switch' statem...
====================================================================== 

---------------------------------------------------------------------- 
 (0131911) svnbot (reporter) - 2011-02-14 00:54
 https://issues.asterisk.org/view.php?id=18729#c131911 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 307751

_U  trunk/
U   trunk/apps/app_dial.c
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r307751 | tilghman | 2011-02-14 00:54:08 -0600 (Mon, 14 Feb 2011) | 30
lines

Merged revisions 307750 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r307750 | tilghman | 2011-02-14 00:50:23 -0600 (Mon, 14 Feb 2011) | 23
lines

  Calling a gosub routine defined in AEL from Dial/Queue ceased to work.

  A bug in AEL did not distinguish between the "s" extension generated by
  AEL and an "s" extension that was required to exist by the chan_dahdi
  (or another channel) that was not supplied with a starting extension.
  Therefore, AEL made incorrect assumptions about what commands were
  permissable in the context.  This was fixed by making AEL generate a
  different extension name.  However, Dial and Queue make additional
  assumptions about the name of the default gosub extension.  Therefore,
  they needed to be brought into line with a "macro" rendered by AEL (as
  a gosub), without breaking traditional dialplans written without the
  aid of AEL.

  Related to (issue https://issues.asterisk.org/view.php?id=18480)
   Reported by: nivek

  (closes issue https://issues.asterisk.org/view.php?id=18729)
   Reported by: kkm
   Patches: 
         20110209__issue18729.diff.txt uploaded by tilghman (license 14)
         018729-dial-queue-gosub-try3.patch uploaded by kkm (license 888)
   Tested by: kkm
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=307751 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-14 00:54 svnbot         Checkin                                      
2011-02-14 00:54 svnbot         Note Added: 0131911                          
======================================================================