[asterisk-bugs] [Asterisk 0018729]: [patch] [regression] Dial() and Queue() with a macro argument are broken by AEL macro compilation change

Asterisk Bug Tracker noreply at bugs.digium.com
Mon Feb 14 00:50:26 CST 2011


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18729 
====================================================================== 
Reported By:                kkm
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18729
Category:                   PBX/pbx_ael
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.8.3-rc2 
JIRA:                       SWP-3052 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-02-02 04:15 CST
Last Modified:              2011-02-14 00:50 CST
====================================================================== 
Summary:                    [patch] [regression] Dial() and Queue() with a macro
argument are broken by AEL macro compilation change
Description: 
Macros used to compile using 's' as the entry point, and that changed to
'~~s~~'. The change broke the macro argument to Dial and Queue
applications.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018480 [patch] Contexts with a 'switch' statem...
====================================================================== 

---------------------------------------------------------------------- 
 (0131909) svnbot (reporter) - 2011-02-14 00:50
 https://issues.asterisk.org/view.php?id=18729#c131909 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 307750

U   branches/1.8/apps/app_dial.c
U   branches/1.8/apps/app_queue.c

------------------------------------------------------------------------
r307750 | tilghman | 2011-02-14 00:50:24 -0600 (Mon, 14 Feb 2011) | 23
lines

Calling a gosub routine defined in AEL from Dial/Queue ceased to work.

A bug in AEL did not distinguish between the "s" extension generated by
AEL and an "s" extension that was required to exist by the chan_dahdi
(or another channel) that was not supplied with a starting extension.
Therefore, AEL made incorrect assumptions about what commands were
permissable in the context.  This was fixed by making AEL generate a
different extension name.  However, Dial and Queue make additional
assumptions about the name of the default gosub extension.  Therefore,
they needed to be brought into line with a "macro" rendered by AEL (as
a gosub), without breaking traditional dialplans written without the
aid of AEL.

Related to (issue https://issues.asterisk.org/view.php?id=18480)
 Reported by: nivek

(closes issue https://issues.asterisk.org/view.php?id=18729)
 Reported by: kkm
 Patches: 
       20110209__issue18729.diff.txt uploaded by tilghman (license 14)
       018729-dial-queue-gosub-try3.patch uploaded by kkm (license 888)
 Tested by: kkm

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=307750 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-14 00:50 svnbot         Checkin                                      
2011-02-14 00:50 svnbot         Note Added: 0131909                          
======================================================================




More information about the asterisk-bugs mailing list