[asterisk-bugs] [Asterisk 0018790]: [patch] Deadlock In chan_sip (conlock / cb_extensionstate

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18790 
====================================================================== 
Reported By:                irroot
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18790
Category:                   Channels/chan_sip/General
Reproducibility:            random
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.2.16.1 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-02-11 01:40 CST
Last Modified:              2011-02-11 04:47 CST
====================================================================== 
Summary:                    [patch] Deadlock In chan_sip (conlock /
cb_extensionstate
Description: 

There is a deadlock in processing state changes it would appear conlock
should be locked when calling cb_extensionstate from chan_sip.c ...

have a patch ill be loading up in a follow up.

this was a problem in 1.4 that i hacked to death to make it go away this
patch seems to make more sense.

NB we have only now moved from 1.4.36 [with backports] to 1.6.2.16.1 this
problem affects sites with higher call volume and reliance on BLF
[Snom/Polycom] and may be triggered on a sip/system reload
====================================================================== 

---------------------------------------------------------------------- 
 (0131850) schmidts (manager) - 2011-02-11 04:47
 https://issues.asterisk.org/view.php?id=18790#c131850 
---------------------------------------------------------------------- 
but you dont have to take the conlock there cause cb_extensionstate calles
transmit_state_notify which calles ast_get_hint which calles
ast_hint_extension and there you have the conlock allready and IMHO this is
the only place where you need the conlock when you access the extension
list.

the only thing you change with the conlock in your patch is to lock it
again and for a longer time which could cause other problems.


best regards

stefan 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-11 04:47 schmidts       Note Added: 0131850                          
======================================================================