[asterisk-bugs] [Asterisk 0018718]: [regression] Implicit declaration of copy yields broken app_voicemail when building with IMAP support

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18718 
====================================================================== 
Reported By:                kerframil
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   18718
Category:                   Applications/app_voicemail/IMAP
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.39.1 
JIRA:                       SWP-3056 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-01-31 15:24 CST
Last Modified:              2011-02-08 13:18 CST
====================================================================== 
Summary:                    [regression] Implicit declaration of copy yields
broken app_voicemail when building with IMAP support
Description: 
While upgrading from 1.4.37 to 1.4.39.1, I noticed the following anomaly
during compilation:

app_voicemail.c: In function 'vm_forwardoptions':
app_voicemail.c:5209: warning: implicit declaration of function 'copy'

I then observed that app_voicemail.so could not be loaded into the
resulting instance of asterisk:

[Jan 31 07:42:16] WARNING[30718]: loader.c:382 load_dynamic_module:
Error loading module 'app_voicemail.so':
/usr/lib64/asterisk/modules/app_voicemail.so: undefined symbol: copy

This apparent regression was introduced by r295200 in the 1.4 branch
(committed by jpeeler). In particular, lines
https://issues.asterisk.org/view.php?id=5209 and
https://issues.asterisk.org/view.php?id=5212 seem to be to
blame. They both call upon copy(), something which - as far as I can tell -
is defined alternately in imap/mail.h (from c-client) and in
app_voicemail.c itself if IMAP_STORAGE is _not_ defined, so I suppose
that's where the problem stems from. I don't know how to fix this in the
appropriate fashion so, for now, I opted to revert the changes that trigger
this problem.
====================================================================== 

---------------------------------------------------------------------- 
 (0131689) svnbot (reporter) - 2011-02-08 13:18
 https://issues.asterisk.org/view.php?id=18718#c131689 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 306960

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r306960 | jpeeler | 2011-02-08 13:18:50 -0600 (Tue, 08 Feb 2011) | 9 lines

Backup file storing message duration is not used with IMAP_STORAGE, remove
code.

The message duration is stored in the body of the email when using
IMAP_STORAGE,
so nothing needs to happen with the backup file.

(closes issue https://issues.asterisk.org/view.php?id=18718)
Reported by: kerframil


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=306960 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-08 13:18 svnbot         Checkin                                      
2011-02-08 13:18 svnbot         Note Added: 0131689                          
2011-02-08 13:18 svnbot         Status                   acknowledged =>
assigned
2011-02-08 13:18 svnbot         Assigned To               => jpeeler         
======================================================================