[asterisk-bugs] [Asterisk 0017255]: [patch] UDP ports not freed/ports leaking

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17255 
====================================================================== 
Reported By:                kvveltho
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17255
Category:                   Core/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.2.7-rc2 
JIRA:                       SWP-1410 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-04-28 06:23 CDT
Last Modified:              2011-02-08 03:57 CST
====================================================================== 
Summary:                    [patch] UDP ports not freed/ports leaking
Description: 
The following is not fixed:

These release candidates resolve an issue with UDP ports not being freed,
per
issue https://issues.asterisk.org/view.php?id=16774
(https://issues.asterisk.org/view.php?id=16774)

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016774 [patch] [regression] 1.6.1.13 and 1.6.1...
related to          0018121 Early bind of UDPTL ports can create a ...
====================================================================== 

---------------------------------------------------------------------- 
 (0131650) rgagnon (reporter) - 2011-02-08 03:57
 https://issues.asterisk.org/view.php?id=17255#c131650 
---------------------------------------------------------------------- 
Thanks for the help with this!  I will look into __sip_autodestruct() in
the morning (4am here for me right now).

It appears that MAYBE the dialog object is not supposed to be completely
removed from memory in that method, but the change I made would ensure it
is.

If you look throughout the code, anywhere you see a call to
dialog_unlink_all(), it is followed by one more dialog_unref()... This is
to account for the single reference applied to the object during
sip_alloc().  I had added the extra unref there in order to account for
this pattern everywhere else in the code.

I will have to wait till tomorrow to see if reverting the change in that
function will still NOT hang up memory and UDP ports, or maybe it will need
to be conditional in order to work for static file configs as well as
realtime. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-08 03:57 rgagnon        Note Added: 0131650                          
======================================================================