[asterisk-bugs] [Asterisk 0018737]: [patch] MWI subscription to remote server crashes during parse

[Asterisk Bug Tracker]

The following issue is now READY FOR REVIEW. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18737 
====================================================================== 
Reported By:                cmaj
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18737
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     ready for review
Asterisk Version:           1.8.2.3 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-02-02 20:50 CST
Last Modified:              2011-02-07 13:41 CST
====================================================================== 
Summary:                    [patch] MWI subscription to remote server crashes
during parse
Description: 
Incorrect parsing in sip_subscribe_mwi was crashing Asterisk.

In sip.conf, just below your "register =>" lines and before peer/user
definitions, try adding:

mwi => 1234 at other_host/1234

...then issue "sip reload" - should crash.

Partial gdb backtrace:

(gdb) bt
https://issues.asterisk.org/view.php?id=0  0x00007fa68aabb990 in strchr () from
/lib/libc.so.6
https://issues.asterisk.org/view.php?id=1  0x00007fa65c0d4af7 in
sip_subscribe_mwi (value=0x0, lineno=0) at
chan_sip.c:7594

Attached patch corrects the problem.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-07 13:41 lmadsen        Status                   new => ready for review
======================================================================