[asterisk-bugs] [Asterisk 0018283]: [patch] Manager eventfilter: black filters aren't applied properly

[Asterisk Bug Tracker]

The following issue has been RESOLVED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18283 
====================================================================== 
Reported By:                telecos82
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   18283
Category:                   Core/ManagerInterface
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
JIRA:                       SWP-2552 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 294314 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-11-09 10:16 CST
Last Modified:              2011-02-04 16:37 CST
====================================================================== 
Summary:                    [patch] Manager eventfilter: black filters aren't
applied properly
Description: 
When having defined more than one black filters on eventfilter parameters,
they do not apply properly: none of them matches. It only works if you have
only one black filter defined. For example, if we have:

eventfilter = !Event: Newexten.*Application: Playback
eventfilter = !Event: Newexten.*Application: Answer

both Newexten events will be received, despite we are trying to avoid
them.

The problem is that when comparing with blackfilters, it stops comparing
when the Event does not match with a filter (which means accept the Event),
but as we are comparing for black filters, we should stop only when we
match a filter and then discard the event.
====================================================================== 

---------------------------------------------------------------------- 
 (0131519) svnbot (reporter) - 2011-02-04 16:37
 https://issues.asterisk.org/view.php?id=18283#c131519 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 306432

U   trunk/main/manager.c

------------------------------------------------------------------------
r306432 | jpeeler | 2011-02-04 16:37:12 -0600 (Fri, 04 Feb 2011) | 10
lines

Send manager event for blackfilter only if it DOES NOT match.

The logic got reversed, oops. Works properly now when multiple
blackfilters are
present.

(closes issue https://issues.asterisk.org/view.php?id=18283)
Reported by: telecos82
Patches: 
      ast_managereventfilter.patch uploaded by telecos82 (license 687)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=306432 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-04 16:37 svnbot         Checkin                                      
2011-02-04 16:37 svnbot         Note Added: 0131519                          
2011-02-04 16:37 svnbot         Status                   ready for testing =>
assigned
2011-02-04 16:37 svnbot         Assigned To               => jpeeler         
2011-02-04 16:37 svnbot         Status                   assigned => resolved
2011-02-04 16:37 svnbot         Resolution               open => fixed       
======================================================================