[asterisk-bugs] [DAHDI-linux 0013205]: [patch] bad master selection

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=13205 
====================================================================== 
Reported By:                biohumanoid
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13205
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2008-07-31 00:11 CDT
Last Modified:              2011-02-02 13:28 CST
====================================================================== 
Summary:                    [patch] bad master selection
Description: 
Current dahdi master handling work in the following way:
The first SPAN become a master
If a new registered !!! SPAN is preferred , it is the new master
If a span is unregistered - the new master is the first available span
If master SPAN is in alarm state - the new master is the first non in
alarm state SPAN

So
1. dahdi-dummy once loaded will be the master forever.
2. even not-running SPAN can be a master
3. master implementation is ugly...
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013206 [patch] ztdynamic double buffering on r...
====================================================================== 

---------------------------------------------------------------------- 
 (0131405) svnbot (reporter) - 2011-02-02 13:28
 https://issues.asterisk.org/view.php?id=13205#c131405 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 9729

U   linux/trunk/drivers/dahdi/dahdi-base.c

------------------------------------------------------------------------
r9729 | sruffell | 2011-02-02 13:28:41 -0600 (Wed, 02 Feb 2011) | 16 lines

dahdi: Analog spans do not have to be marked RUNNING to become master.

Fixes a regression introduced in r9611. Analog spans would never become
the master since the SPANSTART ioctl is not typically called on them,
and therefore they were never marked RUNNING.  The result could be audio
problems.

I'm marking this as related to issue 13205 since it's generally all
related to how should the drivers select which span is the master.  I
also mark as related to issue 16165 because the problems experienced are
a result of the same fundamental issue.

(issue https://issues.asterisk.org/view.php?id=13205)(issue
https://issues.asterisk.org/view.php?id=16165)

Reported-and-Tested-by: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Signed-off-by: Shaun Ruffell <sruffell at digium.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9729 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-02 13:28 svnbot         Note Added: 0131405                          
======================================================================