[asterisk-bugs] [Asterisk 0018545]: [patch] IAX Incorrectly reports IAX/Registry astdb host:port invalid

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18545 
====================================================================== 
Reported By:                jcovert
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   18545
Category:                   Channels/chan_iax2
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.8.4
Asterisk Version:           SVN 
JIRA:                       SWP-2823 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-12-28 15:15 CST
Last Modified:              2011-02-01 16:48 CST
====================================================================== 
Summary:                    [patch] IAX Incorrectly reports IAX/Registry astdb
host:port invalid
Description: 
When the IAX2 channel reviews the registration database, messages such as
the following are reported:

[Dec 28 15:36:32] NOTICE[15998]: chan_iax2.c:8618 reg_source_db:
IAX/Registry astdb host:port invalid - '192.168.0.17:4569

However, this is perfectly valid.  This is caused by an incorrect test:

       if (ast_sockaddr_parse(&p->addr, data, PARSE_PORT_REQUIRE)) {
               ast_log(LOG_NOTICE, "IAX/Registry astdb host:port invalid -
'%s'\n", data);
               return;
       }

As documented in netsock2.h:

 * \retval 0 Failure
 * \retval non-zero The number of elements in addrs array.

(which is only partially true: if there were more then 1 elements in the
array, a warning would be printed and retval would be forced to 1)

In any case, the sense of the test needs to be reversed.  A patch is
attached.
====================================================================== 

---------------------------------------------------------------------- 
 (0131372) svnbot (reporter) - 2011-02-01 16:48
 https://issues.asterisk.org/view.php?id=18545#c131372 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 305693

_U  trunk/
U   trunk/channels/chan_iax2.c

------------------------------------------------------------------------
r305693 | qwell | 2011-02-01 16:48:56 -0600 (Tue, 01 Feb 2011) | 14 lines

Merged revisions 305692 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r305692 | qwell | 2011-02-01 16:48:16 -0600 (Tue, 01 Feb 2011) | 7 lines
  
  Reverse sense of an error test when reading from astdb.
  
  (closes issue https://issues.asterisk.org/view.php?id=18545)
  Reported by: jcovert
  Patches: 
        chan_iax2.c.patch uploaded by jcovert (license 551)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=305693 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-02-01 16:48 svnbot         Checkin                                      
2011-02-01 16:48 svnbot         Note Added: 0131372                          
======================================================================