[asterisk-bugs] [Asterisk 0019199]: [patch] MaxMsg Quota Only Enforced on INBOX Messages for Filesystem Based Voice Mail Boxes

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19199 
====================================================================== 
Reported By:                Jamuel
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19199
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.2.18 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-04-28 19:13 CDT
Last Modified:              2011-04-28 22:39 CDT
====================================================================== 
Summary:                    [patch] MaxMsg Quota Only Enforced on INBOX Messages
for Filesystem Based Voice Mail Boxes
Description: 
When a caller attempts to leave a message for a VM user app_voicemail does
not count messages in other folders in the user's mailbox (e.g. Old,
Urgent, Friends, Family, CustX) in consideration of maxmsg limit.  

The maxmsg setting which is supposed limit total messages per folder does
not work as anticipated as a user could individually (or in aggregate) have
more messages than maxmsg allows just as long as the number contained in
INBOX is less than maxmsg.  It appears that the file-based count_messages
function only ever checks INBOX.

NB: the maxmsg setting has been interpreted to be a setting to control the
total number messages for each user (mailbox) folder and not each
sub-folder that may optionally be contained within the user's mailbox
folder.
====================================================================== 

---------------------------------------------------------------------- 
 (0134266) elguero (reporter) - 2011-04-28 22:39
 https://issues.asterisk.org/view.php?id=19199#c134266 
---------------------------------------------------------------------- 
To me this is a nice feature to add, but obviously it will not go into the
1.6.2 branch.

This patch, to me, is not the right way to add this feature.  Perhaps you
should look at trunk and think about how to implement an overall quota
limit per mailbox.  I could see a global setting and a per user setting.  I
wouldn't touch count_messages at all.  That needs to keep the same
functionality that it was written to do.

Nice idea... just wrong approach.

BTW: All the code documentation and the sample config file state clearly
that maxmsg is per folder, not per mailbox.  Perhaps a different name could
be proposed for the setting which would be applied to trunk to clarify the
setting such as maxmsgsperfolder or something along those lines. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-28 22:39 elguero        Note Added: 0134266                          
======================================================================