[asterisk-bugs] [Asterisk 0018514]: Problem with dialing SIP peer that is not reachable.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18514 
====================================================================== 
Reported By:                jarekj
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18514
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.8.1.1 
JIRA:                       SWP-2807 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-12-21 15:32 CST
Last Modified:              2011-04-28 14:21 CDT
====================================================================== 
Summary:                    Problem with dialing SIP peer that is not reachable.
Description: 
I am using:

*CLI> core show version
Asterisk 1.8.1.1 built by root @ asterisk on a i686 running Linux on
2010-12-17 23:03:58 UTC

I have some problem with DIal() to SIP unreachable friend.

My dialplan:

exten => _XXXX,1,Dial(SIP/${EXTEN},60,rt)

Now, when I Dial extension 1050, and there is no 1050 peer registered I
got:

[Dec 18 22:51:04] WARNING[2307] chan_sip.c: sip_xmit of 0xc2e1330 (len
843) to 0.0.4.26:5060 returned -1: Invalid argument

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0019087 chan_sip.c:3115 __sip_xmit: sip_xmit of...
====================================================================== 

---------------------------------------------------------------------- 
 (0134247) satish_lx (reporter) - 2011-04-28 14:21
 https://issues.asterisk.org/view.php?id=18514#c134247 
---------------------------------------------------------------------- 
You know i have hack this in code and fix issue but i don't what to do
that. i would like to maintain this by community. what is did is
following.

in chan_sip.c file 

 /* Do not retransmit if time out is reached. This will be negative if the
time between
         * the first transmission and now is larger than our timeout
period. This is a fail safe
         * check in case the scheduler gets behind or the clock is
changed. */
        if ((diff <= 0) || (diff > pkt->retrans_stop_time)) {
                pkt->retrans_stop = 1;
        }


I have changed 

((diff <= 0) || (diff > pkt->retrans_stop_time)) {

to 

((diff != 0) || (diff > pkt->retrans_stop_time)) {


And it fixed my issue now its not waiting for timeout and re-transmit
packet on dead unavailable peer. But i would like if asterisk community
sign off and say this is good to go. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-28 14:21 satish_lx      Note Added: 0134247                          
======================================================================