[asterisk-bugs] [Asterisk 0019185]: Asterisk crashes with a segfault if current host cannot be resolved via DNS.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19185 
====================================================================== 
Reported By:                dswartz
Assigned To:                may213
====================================================================== 
Project:                    Asterisk
Issue ID:                   19185
Category:                   Addons/chan_ooh323
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.8.3.3 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-04-26 13:46 CDT
Last Modified:              2011-04-28 07:53 CDT
====================================================================== 
Summary:                    Asterisk crashes with a segfault if current host
cannot be resolved via DNS.
Description: 
int ooGetLocalIPAddress(char * pIPAddrs)
{
   int ret;
   struct hostent *hp;
   struct ast_hostent phost;
   char hostname[100];

   if(pIPAddrs == NULL)
      return -1; /* Need to find suitable return value */
   ret = gethostname(hostname, 100);
   if(ret == 0)
   {
      if (!(hp = ast_gethostbyname(hostname, &phost))) {
                        struct in_addr i;
                        memcpy(&i, hp->h_addr, sizeof(i));

If gethostname() fails, and then ast_gethostbyname() does as well, we will
go to the memcpy, dereferencing the null 'hp'.

====================================================================== 

---------------------------------------------------------------------- 
 (0134227) dswartz (reporter) - 2011-04-28 07:53
 https://issues.asterisk.org/view.php?id=19185#c134227 
---------------------------------------------------------------------- 
I agree.  It looks like it was fixed by the work done for bugfix 0018278. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-28 07:53 dswartz        Note Added: 0134227                          
======================================================================