[asterisk-bugs] [Asterisk 0018951]: [patch] [regression] Cisco phones do not register

Wed Apr 27 13:57:59 CDT 2011

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18951 
====================================================================== 
Reported By:                jmls
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   18951
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Target Version:             1.4/1.6.2 Issues (Final Release)
Asterisk Version:           SVN 
JIRA:                       SWP-3257 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 309947 
Request Review:              
====================================================================== 
Date Submitted:             2011-03-09 15:40 CST
Last Modified:              2011-04-27 13:57 CDT
====================================================================== 
Summary:                    [patch] [regression] Cisco phones do not register
Description: 
Prior to r304241, cisco phones worked fine. After this revision, cisco 79xx
phones do not register with asterisk.
====================================================================== 

---------------------------------------------------------------------- 
 (0134206) svnbot (reporter) - 2011-04-27 13:57
 https://issues.asterisk.org/view.php?id=18951#c134206 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 315891

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r315891 | mnicholson | 2011-04-27 13:57:57 -0500 (Wed, 27 Apr 2011) | 14
lines

Fix our compliance with RFC 3261 section 18.2.2.

This change optimizes the free_via() function and removes some redundant
null
checking. It also fixes compliance with RFC 3261 section 18.2.2 by always
using
the port specified in the Via header for routing responses (even when
maddr is
not set). Also the htons() function is now used when setting the port.
Additional documentation comments have been added in various places to
make the
logic in the code clearer.

(closes issue https://issues.asterisk.org/view.php?id=18951)
Reported by: jmls
Patches:
      issue18951_set_proper_port_from_via.patch uploaded by wdoekes
(license 717) (modified)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=315891 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-27 13:57 svnbot         Note Added: 0134206                          
======================================================================