[asterisk-bugs] [Asterisk 0019176]: [patch] check_bridge(): misplaced ast_mutex_unlock

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19176 
====================================================================== 
Reported By:                alecdavis
Assigned To:                alecdavis
====================================================================== 
Project:                    Asterisk
Issue ID:                   19176
Category:                   Channels/chan_local
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-04-25 02:00 CDT
Last Modified:              2011-04-25 02:11 CDT
====================================================================== 
Summary:                    [patch] check_bridge(): misplaced ast_mutex_unlock
Description: 
<pre>
if (!ast_mutex_trylock(&(p->chan->_bridge)->lock)) {
  if (!p->chan->_bridge->_softhangup) {
    ....
    ast_mutex_unlock(&(p->chan->_bridge)->lock); <b><u> <<< WHAT </u></b>
  }
}</pre>
====================================================================== 

---------------------------------------------------------------------- 
 (0134066) svnbot (reporter) - 2011-04-25 02:11
 https://issues.asterisk.org/view.php?id=19176#c134066 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 315052

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_local.c

------------------------------------------------------------------------
r315052 | alecdavis | 2011-04-25 02:11:13 -0500 (Mon, 25 Apr 2011) | 16
lines

Merged revisions 315051 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r315051 | alecdavis | 2011-04-25 19:06:29 +1200 (Mon, 25 Apr 2011) | 11
lines
  
  chan_local:check_bridge() misplaced misplaced ast_mutex_unlock 
  
  if !p->chan->_bridge->_softhangup path isn't followed, brigde remains
locked.
  
  (closes issue https://issues.asterisk.org/view.php?id=19176)
  Reported by: alecdavis
  Patches: 
        bug19176.diff.txt uploaded by alecdavis (license 585)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=315052 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-25 02:11 svnbot         Checkin                                      
2011-04-25 02:11 svnbot         Note Added: 0134066                          
======================================================================