[asterisk-bugs] [Asterisk 0019137]: [patch] appdata truncated

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19137 
====================================================================== 
Reported By:                larubbio
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19137
Category:                   Applications/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-04-18 21:57 CDT
Last Modified:              2011-04-19 01:53 CDT
====================================================================== 
Summary:                    [patch] appdata truncated
Description: 
Running against both asterisk v1.6 and 1.8 we are seeing an issue with the
url sent to voiceglue is getting truncated.  Specifically if we send this
message:

action: Originate
actionid: 33517025_5#AJ_ORIGINATE_0
application: Agi
data:
agi://localhost/url=http%3A%2F%2F192.168.1.107%3A8080%2Fm%2Fmodule%2Far%2Fvxml%2Far%3Fr%3D1
async: true
variable: __AJ_TRACE_ID=AJ_ORIGINATE_0
channel: SIP/1000
timeout: 10000

What gets passed to voiceglue is this URL: 
http://192.168.1.107:8080/m/module/ar/vxml%

it looks like in main/manager.c in action_originate (Line 3907) it copies
the data element of the message into a fast_orginate_helper struct:

ast_copy_string(fast->appdata, appdata, sizeof(fast->appdata));

However the struct definition for fast_originate_helper only provides 80
characters for appdata (char appdata[AST_MAX_EXTENSION];) and that isn't
big enough for a URL.  (elsewhere in the code I've seen appdata set to
1024)

Not only should that buffer be larger, but the app_tmp structure in
main/pbx.c also needs to be increased (beyond the 256 character limit).
(from Tilghman Lesher on asterisk-dev)
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-19 01:53 tilghman       Status                   new => ready for
testing
======================================================================