[asterisk-bugs] [Asterisk 0018654]: [patch] [regression] Call Pickup Hangs Asterisk (deadlock?)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18654 
====================================================================== 
Reported By:                Docent
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18654
Category:                   Features
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-3085 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-01-21 01:16 CST
Last Modified:              2011-04-18 22:53 CDT
====================================================================== 
Summary:                    [patch] [regression] Call Pickup Hangs Asterisk
(deadlock?)
Description: 
Asterisk stops to service new calls when someone tries to pickup a call by
pressing *8. Some existing calls are also terminated, although others
continue to work. I still can run any command in the console, but I can't
stop or kill Asterisk. I can kill it only with -9 flag.
I found this trouble in versions 1.8.1, 1.8.2 and SVN.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0018906 Deadlock using pickup extension
has duplicate       0018955 after picking up a call, phones stop wo...
has duplicate       0019092 Calls getting stuck when dialing *8
====================================================================== 

---------------------------------------------------------------------- 
 (0133904) alecdavis (manager) - 2011-04-18 22:53
 https://issues.asterisk.org/view.php?id=18654#c133904 
---------------------------------------------------------------------- 
In ast_pickup_call() from 1.4 res/res_features.c and in 1.6.2
main/features.c the unlock(cur) is after the ast_channel_masquerade and
ast_stream_and_wait.

In 1.8 and trunk the unlock is before everything, allowing masquerading to
cause havoc!

I'm conviced bug18654.diff2.txt is the correct fix for this bug. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-18 22:53 alecdavis      Note Added: 0133904                          
======================================================================