[asterisk-bugs] [Asterisk 0019134]: [patch] Unclear code in app_dial.c

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19134 
====================================================================== 
Reported By:                oej
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   19134
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.2.4 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-04-18 09:03 CDT
Last Modified:              2011-04-18 11:25 CDT
====================================================================== 
Summary:                    [patch] Unclear code in app_dial.c
Description: 
The code that handles AST_CONTROL_PROGRESS in the function wait_for_answer
has unclear formatting. The line checking for OPT_RINGBACK has no curly
brackets, so it only applies to the next level if. There's a second if()
statement where indents indicate that it should be part of the RINGBACK
clause, but it is not. I can't say what's righ there, so someone else needs
to check the code and decide. Thanks.
====================================================================== 

---------------------------------------------------------------------- 
 (0133878) svnbot (reporter) - 2011-04-18 11:25
 https://issues.asterisk.org/view.php?id=19134#c133878 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 314079

_U  trunk/
U   trunk/apps/app_dial.c

------------------------------------------------------------------------
r314079 | rmudgett | 2011-04-18 11:25:07 -0500 (Mon, 18 Apr 2011) | 14
lines

Merged revisions 314068 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r314068 | rmudgett | 2011-04-18 11:02:12 -0500 (Mon, 18 Apr 2011) | 7
lines
  
  Unclear code in app_dial.c.
  
  Make code formatting clear.
  
  (closes issue https://issues.asterisk.org/view.php?id=19134)
  Reported by: oej
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=314079 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-18 11:25 svnbot         Checkin                                      
2011-04-18 11:25 svnbot         Note Added: 0133878                          
======================================================================