[asterisk-bugs] [Asterisk 0019082]: [patch] [regression] Blind transfers from queue are not logged into queue_log correctly

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19082 
====================================================================== 
Reported By:                garlew
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19082
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.8.3.2 
JIRA:                        
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-04-07 12:10 CDT
Last Modified:              2011-04-07 13:22 CDT
====================================================================== 
Summary:                    [patch] [regression] Blind transfers from queue are
not logged into queue_log correctly
Description: 
In 1.4 blind transfers from queue were correctly logged as TRANSFER.
starting with 1.6.x they are no more logged as TRANSFER but as
COMPLETEAGENT. I believe this is a regression related to issue 0014536.
This was a fix for 1.4 merged into 1.6. It adds a test condition:
!(qe->chan->_softhangup | peer->_softhangup). But in 1.4 peer->_softhangup
was 1 during blind transfer and in 1.6.2 up peer->_softhangup is 0. This
results in dead code for blind transfer logging. The trivial fix would be
to revert 0014536-related changes (patch included) because when following
issue pattern from 0014536 in 1.6.2 up this condition is no longer even
tested. 
The remaining question is if it is ok that peer->_softhangup is now 0.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014536 [patch] After a caller is processed by ...
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-07 13:22 lmadsen        Description Updated                          
======================================================================