[asterisk-bugs] [Asterisk 0019062]: [patch] ISDN party subaddress odd_even_indicator inconsitency / undocumented

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19062 
====================================================================== 
Reported By:                festr
Assigned To:                alecdavis
====================================================================== 
Project:                    Asterisk
Issue ID:                   19062
Category:                   Channels/chan_dahdi
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                       SWP-3302 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 311931 
Request Review:              
====================================================================== 
Date Submitted:             2011-04-04 06:35 CDT
Last Modified:              2011-04-07 05:19 CDT
====================================================================== 
Summary:                    [patch] ISDN party subaddress odd_even_indicator
inconsitency / undocumented
Description: 
I'm playing with party subaddress -> Call(DAHDI/g1/1234:u0a23a4)

this syntax should set party subaddress to user specified and
odd_even_indicator to 0. Unfortunatly, odd_even_indicator is overwritten in
channels/sig_pri.c in function sig_pri_party_subaddress_from_ast:
pri_subaddress->odd_even_indicator = (length & 1); 

So you cannot set your own odd_even_indicator specified by prefix 'u' or
'U' as it depends always on string length. I've hacked it by uncommenting
"pri_subaddress->odd_even_indicator = (length & 1);" 
====================================================================== 

---------------------------------------------------------------------- 
 (0133495) svnbot (reporter) - 2011-04-07 05:19
 https://issues.asterisk.org/view.php?id=19062#c133495 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 313001

U   branches/1.8/channels/sig_pri.c

------------------------------------------------------------------------
r313001 | alecdavis | 2011-04-07 05:19:32 -0500 (Thu, 07 Apr 2011) | 13
lines

Fix ISDN calling subaddr User Specified Odd/Even Flag

Calculation of the Odd/Even flag was wrong.
Implement correct algo, and set odd/even=0 if data would be truncated.
Only allow automatic calculation of the O/E flag, don't let dialplan
influence.

(closes issue https://issues.asterisk.org/view.php?id=19062)
Reported by: festr
Patches: 
      bug19062.diff2.txt uploaded by alecdavis (license 585)
Tested by: festr, alecdavis, rmudgett


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=313001 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-07 05:19 svnbot         Checkin                                      
2011-04-07 05:19 svnbot         Note Added: 0133495                          
2011-04-07 05:19 svnbot         Status                   ready for testing =>
assigned
2011-04-07 05:19 svnbot         Assigned To               => alecdavis       
======================================================================