[asterisk-bugs] [Asterisk 0018018]: [patch] Hints for non-existent devices are in an Idle state

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18018 
====================================================================== 
Reported By:                ebroad
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18018
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-2283 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 287310 
Request Review:              
====================================================================== 
Date Submitted:             2010-09-20 09:37 CDT
Last Modified:              2011-04-06 11:36 CDT
====================================================================== 
Summary:                    [patch] Hints for non-existent devices are in an
Idle state
Description: 
bhn-pbx01*CLI> core show hint 900
900 at broadhn-internal    : SIP/foo             State:Idle           
Watchers  0
1 hint matching extension 900


foo is not a valid SIP device:

bhn-pbx01*CLI> sip show peer foo
Peer foo not found.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016035 [patch] Status of dahdi/zap channels in...
related to          0018860 [patch] Odd Behavior when dialed sip ch...
====================================================================== 

---------------------------------------------------------------------- 
 (0133448) ebroad (manager) - 2011-04-06 11:36
 https://issues.asterisk.org/view.php?id=18018#c133448 
---------------------------------------------------------------------- 
I believe agg->all_unavail defaults to 1 in ast_devstate_aggregate_init(),
so it should be handled correctly ast_devstate_aggregate_result(),
additionally, I believe sip_devicestate() is called by devicestate.c, so
returning the wrong mapping for a single device is going to mess with our
aggregate result. The 2nd part of the problem is the device state to
extension state mappings, by returning AST_DEVICE_UNKNOWN for a single
invalid device or invalid aggregate list of devices, our total device state
is AST_DEVICE_UNKNOWN, which according the devicestate enum, means that the
device or list of devices is valid but of unknown
state(http://www.asterisk.org/doxygen/trunk/devicestate_8h.html#f72f8a5c0601e4c1f8a852749cd44eee),
which isn't true. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-06 11:36 ebroad         Note Added: 0133448                          
======================================================================