[asterisk-bugs] [Asterisk 0019062]: [patch] PRI party subaddress odd_even_indicator inconsitency / undocumented

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19062 
====================================================================== 
Reported By:                festr
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19062
Category:                   Channels/chan_dahdi
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
JIRA:                       SWP-3302 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 311931 
Request Review:              
====================================================================== 
Date Submitted:             2011-04-04 06:35 CDT
Last Modified:              2011-04-06 10:07 CDT
====================================================================== 
Summary:                    [patch] PRI party subaddress odd_even_indicator
inconsitency / undocumented
Description: 
I'm playing with party subaddress -> Call(DAHDI/g1/1234:u0a23a4)

this syntax should set party subaddress to user specified and
odd_even_indicator to 0. Unfortunatly, odd_even_indicator is overwritten in
channels/sig_pri.c in function sig_pri_party_subaddress_from_ast:
pri_subaddress->odd_even_indicator = (length & 1); 

So you cannot set your own odd_even_indicator specified by prefix 'u' or
'U' as it depends always on string length. I've hecked it by uncommenting
"pri_subaddress->odd_even_indicator = (length & 1);" 
====================================================================== 

---------------------------------------------------------------------- 
 (0133444) rmudgett (administrator) - 2011-04-06 10:07
 https://issues.asterisk.org/view.php?id=19062#c133444 
---------------------------------------------------------------------- 
The odd_even_indicator probably should just be copied from the source
subaddress structure.  Just have to trust the source to be correct. :) 
However, the odd/even flag could then become wrong if the conversion had to
truncate the ASCII hex string because of the BCD buffer size.  Truncation
should never be necessary if the subaddress is to get to the other end
correctly.

The existing code is just wrong.  That length is the length of the BCD
buffer not the ASCII hex string length (or adjusted ASCII hex string length
if truncation was needed). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-06 10:07 rmudgett       Note Added: 0133444                          
======================================================================