[asterisk-bugs] [Asterisk 0019062]: [patch] PRI party subaddress odd_even_indicator inconsitency / undocumented

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19062 
====================================================================== 
Reported By:                festr
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19062
Category:                   Channels/chan_dahdi
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
JIRA:                       SWP-3302 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 311931 
Request Review:              
====================================================================== 
Date Submitted:             2011-04-04 06:35 CDT
Last Modified:              2011-04-06 04:01 CDT
====================================================================== 
Summary:                    [patch] PRI party subaddress odd_even_indicator
inconsitency / undocumented
Description: 
I'm playing with party subaddress -> Call(DAHDI/g1/1234:u0a23a4)

this syntax should set party subaddress to user specified and
odd_even_indicator to 0. Unfortunatly, odd_even_indicator is overwritten in
channels/sig_pri.c in function sig_pri_party_subaddress_from_ast:
pri_subaddress->odd_even_indicator = (length & 1); 

So you cannot set your own odd_even_indicator specified by prefix 'u' or
'U' as it depends always on string length. I've hecked it by uncommenting
"pri_subaddress->odd_even_indicator = (length & 1);" 
====================================================================== 

---------------------------------------------------------------------- 
 (0133429) alecdavis (manager) - 2011-04-06 04:01
 https://issues.asterisk.org/view.php?id=19062#c133429 
---------------------------------------------------------------------- 
fest: 
confession time. Agreed in sig_pri_call :Uu was the inital idea (in
https://issues.asterisk.org/view.php?id=15604
diff8 patch) was to allow User Specifed Odd/Even flag to be automatically
calculated.

By diff11 I'd made the change in sig_pri_call to all the user to specify
Odd/Even, but missed the required change in function
sig_pri_party_subaddress_from_ast.

So we shouldn't need another option, and you patch seems correct.

Just need rmudgett to comment, and I'm sure he'll also say oops... 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-06 04:01 alecdavis      Note Added: 0133429                          
======================================================================