[asterisk-bugs] [DAHDI-linux 0019035]: [patch] core timer hangs if time goes back

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19035 
====================================================================== 
Reported By:                tzafrir
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   19035
Category:                   dahdi (the module)
Reproducibility:            have not tried
Severity:                   major
Priority:                   normal
Status:                     assigned
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2011-03-29 10:00 CDT
Last Modified:              2011-04-04 11:24 CDT
====================================================================== 
Summary:                    [patch] core timer hangs if time goes back
Description: 
This is a regression in trunk since r9407. If the time goes back ('date
--set=12:34' if now is 12:36), coretimer_func will loop (almost) forever
waiting for the timer to settle.
====================================================================== 

---------------------------------------------------------------------- 
 (0133352) svnbot (reporter) - 2011-04-04 11:24
 https://issues.asterisk.org/view.php?id=19035#c133352 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 9876

U   linux/trunk/drivers/dahdi/dahdi-base.c

------------------------------------------------------------------------
r9876 | sruffell | 2011-04-04 11:24:27 -0500 (Mon, 04 Apr 2011) | 20 lines

core timer: don't hang when the clock goes back.

If the clock shifts back, don't hang in a loop of running
process_masterspan from the timer interrupt forever.

Fixes a regression of r9407.

(closes issue https://issues.asterisk.org/view.php?id=19035)
Reported by: tzafrir

Signed-off-by: Tzafrir Cohen <tzafrir.cohen at xorcom.com>

After talking with Tzafrir on IRC, I combined the check if your far ahead
with the check if you're behind and added a '\n' at the end of the
existing "detected time shift" message.  That is why this patch is
different than what is posted on issue
https://issues.asterisk.org/view.php?id=19035.

Acked-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Michael Spiceland <mspiceland at digium.com>
Acked-by: Kinsey Moore <kmoore at digium.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9876 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-04 11:24 svnbot         Note Added: 0133352                          
2011-04-04 11:24 svnbot         Status                   ready for testing =>
assigned
2011-04-04 11:24 svnbot         Assigned To               => sruffell        
======================================================================