[asterisk-bugs] [Asterisk 0018763]: [patch] CallCompletionRequest() / Cancel() exit non-zero if no call/pending call

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18763 
====================================================================== 
Reported By:                p_lindheimer
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   18763
Category:                   Core/CallCompletionSupplementaryServices
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.2.3 
JIRA:                       SWP-3042 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-02-07 12:06 CST
Last Modified:              2011-04-01 16:36 CDT
====================================================================== 
Summary:                    [patch] CallCompletionRequest() / Cancel() exit
non-zero if no call/pending call
Description: 
When Calling CallCompletionRequest() if there is no call to make a request
on (timer has expired), or there is already a pending request (in generic
mode) then the call returns with a non-zero return and hangs up the call.

When this happens, in both above scenarios, the following is printed out
the the log/clli:

[Feb  7 09:22:28] CC[10693]: ccss.c:3886 ccreq_exec: Couldn't find a core
instance for caller SIP/3000

in the case where there is a pending request, it is the same message, but
as a result that there was a pending request and thus no instance was saved
from the last call since all 'slots' were taken (max 1 slot for generic).

example, the following occurs upon making a subsequent call elsewhere if
you have a current pending request, thus the above equivalent behavior in
both cases:

[Feb  7 09:22:08] CC[10670]: ccss.c:1522 cc_monitor_destroy: Core 77:
Calling destructor for monitor 2000 at from-internal
[Feb  7 09:22:08] CC[10670]: ccss.c:1415 cc_interface_destroy: Destroying
cc interface 2000 at from-internal
[Feb  7 09:22:08] CC[9099]: ccss.c:2944 cc_do_state_change: Core 77: State
change to 1 requested. Reason: CC offered to caller SIP/3000-00000106
[Feb  7 09:22:08] CC[9099]: ccss.c:2947 cc_do_state_change: Core 77:
Unable to find core instance.

Similar issue when calling CallCompletionCancel() if there is no pending
request to cancel. This results in a non-zero exit as well, but no log
message from the ccss system:


    -- Executing [*83 at from-internal:5]
CallCompletionCancel("SIP/3000-0000010a", "") in new stack
  == Spawn extension (from-internal, *83, 5) exited non-zero on
'SIP/3000-0000010a'

====================================================================== 

---------------------------------------------------------------------- 
 (0133296) svnbot (reporter) - 2011-04-01 16:36
 https://issues.asterisk.org/view.php?id=18763#c133296 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 312462

_U  trunk/
U   trunk/main/ccss.c

------------------------------------------------------------------------
r312462 | rmudgett | 2011-04-01 16:36:53 -0500 (Fri, 01 Apr 2011) | 32
lines

Merged revisions 312461 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r312461 | rmudgett | 2011-04-01 16:31:39 -0500 (Fri, 01 Apr 2011) | 25
lines
  
  CallCompletionRequest()/CallCompletionCancel() exit non-zero if fail.
  
  The CallCompletionRequest()/CallCompletionCancel() dialplan applications
  exit nonzero on normal failure conditions.  The nonzero exit causes the
  dialplan to hangup immediately.  The dialplan author has no opportunity
to
  report success/failure to the user.
  
  * Made always return zero so the dialplan can continue.
  
  * Made set CC_REQUEST_RESULT/CC_REQUEST_REASON and
  CC_CANCEL_RESULT/CC_CANCEL_REASON channel variables respectively.  Also
  documented the values set.
  
  * Reduced the warning about no core instance in CallCompletionCancel()
to
  a debug message.  It is a normal event and should not be output at the
  WARNING level.
  
  (closes issue https://issues.asterisk.org/view.php?id=18763)
  Reported by: p_lindheimer
  Patches:
        ccss.patch uploaded by p lindheimer (license 558) Modified
  Tested by: p_lindheimer, rmudgett
  
  JIRA SWP-3042
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=312462 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-01 16:36 svnbot         Note Added: 0133296                          
======================================================================