[asterisk-bugs] [Asterisk 0018969]: [patch] Dead code - ast_FD_SETSIZE

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18969 
====================================================================== 
Reported By:                oej
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18969
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-3267 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-03-14 08:22 CDT
Last Modified:              2011-04-01 05:36 CDT
====================================================================== 
Summary:                    [patch] Dead code - ast_FD_SETSIZE
Description: 
There is a lot of code in main/asterisk.c that depends on
configure_ran_as_root that aims to set a variable (defined in poll.c)
called ast_FD_SETSIZE: In Asterisk 1.6.0 this variable was used in an
inline function in select.h - but it is now gone (ast_select()).

I can't find the ast_FD_SETSIZE being used anywhere else, so it seems like
we have a lot of dead meat hanging around that needs some cleaning up. This
could potentially affect configure, main/asterisk.c main/poll.c and
select.h (an external reference).
====================================================================== 

---------------------------------------------------------------------- 
 (0133266) svnbot (reporter) - 2011-04-01 05:36
 https://issues.asterisk.org/view.php?id=18969#c133266 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 312285

U   branches/1.4/include/asterisk/select.h
U   branches/1.4/main/asterisk.c

------------------------------------------------------------------------
r312285 | tilghman | 2011-04-01 05:36:43 -0500 (Fri, 01 Apr 2011) | 7
lines

Found some leaking file descriptors while looking at ast_FD_SETSIZE dead
code.

(issue https://issues.asterisk.org/view.php?id=18969)
 Reported by: oej
 Patches: 
       20110315__issue18969__14.diff.txt uploaded by tilghman (license 14)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=312285 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-01 05:36 svnbot         Note Added: 0133266                          
======================================================================