[asterisk-bugs] [Asterisk 0018998]: [patch] Voicemail doesn't read/delete messages in one case

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18998 
====================================================================== 
Reported By:                tootai
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18998
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.4.40 
JIRA:                        
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1153/ 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-03-19 05:57 CDT
Last Modified:              2011-04-01 01:47 CDT
====================================================================== 
Summary:                    [patch] Voicemail doesn't read/delete messages in
one case
Description: 
When listening the voicemailbox and new callers leave a new message
something goes wrong: after the user has read and deleted all messages, the
last one is not destroyed and the new incoming recorded messages are lost.

Below the relevant logs of an user reading his mailbox with 16 messages
waiting (#<b></b>0 to #<b></b>15). During his reading, a new message was
left while reading message #<b></b>5. All 16 messages where destroyed,
voicemailbox should and has one message, number #<b></b>16. But when
calling Voicemailmain, I get:
 
[2011-03-19 11:15:28] NOTICE[28981] app_voicemail.c: Resequencing Mailbox:
/var/spool/asterisk/voicemail/default/100/INBOX, expected 0 but found 1
message(s) in box with max threshold of 100.

app_voicemail.c:5917 play_message: No message attribute file?!!
(/var/spool/asterisk/voicemail/default/100/INBOX/msg0000.txt)

dh at chacomx:/var/spool/asterisk/voicemail/default/100/INBOX$ ls -al
total 532
drwxr-xr-x 2 root root   4096 2011-03-19 11:15 .
drwxr-xr-x 8 root root   4096 2011-03-19 11:14 ..
-rwxr-xr-x 1 root root  45144 2011-03-18 22:00 msg0016.gsm
-rw-r--r-- 1 root root    264 2011-03-18 22:00 msg0016.txt
-rwxr-xr-x 1 root root 437804 2011-03-18 22:00 msg0016.wav
-rwxr-xr-x 1 root root  44520 2011-03-18 22:00 msg0016.WAV

So Asterisk is looking for msg0000 but found msg0016. There is no
possibility to treat this message, only rename the file as msg0000.* give
the possibility to listen and delete it.
====================================================================== 

---------------------------------------------------------------------- 
 (0133240) svnbot (reporter) - 2011-04-01 01:47
 https://issues.asterisk.org/view.php?id=18998#c133240 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 312070

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r312070 | alecdavis | 2011-04-01 01:46:56 -0500 (Fri, 01 Apr 2011) | 16
lines

app_voicemail: close_mailbox needs to respect additional messages while
mailbox is open.

close_mailbox leave gaps in message sequence if messages are deleted and
new messages
arrive during this time, this is because the shuffle down to slot 0, only
shuffles
the number of pre-existing messages when mailbox is opened, ignoring new
arrivals.

Fix: in close_mailbox re-evaluate number of messages before the shuffle,
this then includes new arrivals.

Happens on filebased or ODBC storage.

(issues
https://issues.asterisk.org/view.php?id=19032,https://issues.asterisk.org/view.php?id=18582,https://issues.asterisk.org/view.php?id=18692,https://issues.asterisk.org/view.php?id=18998)
Reported by: alecdavis,tootai,afosorio

Review: https://reviewboard.asterisk.org/r/1153/


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=312070 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-01 01:47 svnbot         Checkin                                      
2011-04-01 01:47 svnbot         Note Added: 0133240                          
======================================================================