[asterisk-bugs] [Asterisk 0018692]: [patch] Compile Error - odbc_storage enabled

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18692 
====================================================================== 
Reported By:                elguero
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18692
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-3021 
Regression:                 Yes 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1153/ 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 304637 
Request Review:              
====================================================================== 
Date Submitted:             2011-01-27 16:44 CST
Last Modified:              2011-04-01 01:46 CDT
====================================================================== 
Summary:                    [patch] Compile Error - odbc_storage enabled
Description: 
After the changes were merged in r303679, there is a compile error with
ODBC storage enabled.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0019032 [patch] Voicemail messages (ODBC), inco...
related to          0018582 Problem reading a message which was pre...
====================================================================== 

---------------------------------------------------------------------- 
 (0133239) svnbot (reporter) - 2011-04-01 01:46
 https://issues.asterisk.org/view.php?id=18692#c133239 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 312070

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r312070 | alecdavis | 2011-04-01 01:46:56 -0500 (Fri, 01 Apr 2011) | 16
lines

app_voicemail: close_mailbox needs to respect additional messages while
mailbox is open.

close_mailbox leave gaps in message sequence if messages are deleted and
new messages
arrive during this time, this is because the shuffle down to slot 0, only
shuffles
the number of pre-existing messages when mailbox is opened, ignoring new
arrivals.

Fix: in close_mailbox re-evaluate number of messages before the shuffle,
this then includes new arrivals.

Happens on filebased or ODBC storage.

(issues
https://issues.asterisk.org/view.php?id=19032,https://issues.asterisk.org/view.php?id=18582,https://issues.asterisk.org/view.php?id=18692,https://issues.asterisk.org/view.php?id=18998)
Reported by: alecdavis,tootai,afosorio

Review: https://reviewboard.asterisk.org/r/1153/


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=312070 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-04-01 01:46 svnbot         Checkin                                      
2011-04-01 01:46 svnbot         Note Added: 0133239                          
======================================================================