[asterisk-bugs] [Asterisk 0017987]: [regression] Newchannel event is missing during masquerading process

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17987 
====================================================================== 
Reported By:                RadicAlish
Assigned To:                bbryant
====================================================================== 
Project:                    Asterisk
Issue ID:                   17987
Category:                   Core/ManagerInterface
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Target Version:             1.4.38
Asterisk Version:           SVN 
JIRA:                       SWP-2203 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 286645 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-09-14 07:48 CDT
Last Modified:              2010-09-28 13:18 CDT
====================================================================== 
Summary:                    [regression] Newchannel event is missing during
masquerading process
Description: 
We have an external application, that uses AMI for call monitoring.
After updating asterisk to 1.4.35 the application started to get many
errors/exceptions
During investigation I found that starting version 1.4.32_rc1 of asterisk
new patch was applied because of bug 16957
(https://issues.asterisk.org/view.php?id=16957
https://reviewboard.asterisk.org/r/601/) and Newchannel event is missing
now in "masquerading process" (for example blind transfer by caller)

See attached trace with example of proper sequence of events (previous
version of asterisk):

As you can see asterisk create new channel AsyncGoto/SIP/100-00000008 with
Uniqueid 1284362350.11 for masquerading (actually it's the only channel
left in this call)
In new versions asterisk doesn't send Newchannel event, but this channel
is still used in following events, and our application can't handle these
events because of uknown Uniqueid
It's buggy behavior to use channel that "wasn't created" (wasn't notified
about new channel)

As I understand the purpose of this patch (16957) is prevent sending of
Newchannel event in case of "fake" channels like Bogus/manager,
Logger/rotate, Substitution/voicemail and so on, but unfortunataly it's
affecting on important channels like AsyncGoto/SIP/100-00000008,
Parking/Zap/1-1, Transferred/IAX2/102-00000001 and may be others.

I have attached patch that fix this:
instead of checking 'AsyncGoto' string in list of supported channel types,
it'll check 'SIP' (string between two slashes)
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016957 [patch] Rogue Newchannel events for fai...
====================================================================== 

---------------------------------------------------------------------- 
 (0127474) svnbot (reporter) - 2010-09-28 13:18
 https://issues.asterisk.org/view.php?id=17987#c127474 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 289099

_U  branches/1.8/
U   branches/1.8/main/channel.c

------------------------------------------------------------------------
r289099 | bbryant | 2010-09-28 13:18:03 -0500 (Tue, 28 Sep 2010) | 28
lines

Merged revisions 289095 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r289095 | bbryant | 2010-09-28 14:14:19 -0400 (Tue, 28 Sep 2010) | 21
lines
  
  Merged revisions 289094 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r289094 | bbryant | 2010-09-28 14:10:19 -0400 (Tue, 28 Sep 2010) | 14
lines
    
    Fixes an issue with the Newchannel AMI event during the Masquerading
process.
    
    Fixes an issue with the Newchannel AMI event during the Masquerading
process,
    where no Newchannel AMI event was generated for the psuedo channel
used during
    the masquerading process.
    
    (closes issue https://issues.asterisk.org/view.php?id=17987)
    Reported by: RadicAlish
    Patches: 
          newchannel.patch.txt uploaded by RadicAlish (license 1122)
          Tested by: RadicAlish
    
          Review: https://reviewboard.asterisk.org/r/937/
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=289099 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-28 13:18 svnbot         Checkin                                      
2010-09-28 13:18 svnbot         Note Added: 0127474                          
======================================================================