[asterisk-bugs] [Asterisk 0016057]: [patch] Asterisk crashes with "Fixup failed on channel XXX, strange things may happen."

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16057 
====================================================================== 
Reported By:                amorsen
Assigned To:                alecdavis
====================================================================== 
Project:                    Asterisk
Issue ID:                   16057
Category:                   Core/General
Reproducibility:            sometimes
Severity:                   crash
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-303 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/928/ 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-10-12 08:23 CDT
Last Modified:              2010-09-20 18:16 CDT
====================================================================== 
Summary:                    [patch] Asterisk crashes with "Fixup failed on
channel XXX, strange things may happen."
Description: 
[Oct 12 11:26:07] WARNING[1684] channel.c: Fixup failed on channel
Local/1127-0004132c4403-1 at DialLine-3d9b;1<MASQ>, strange things may
happen.
[Oct 12 11:26:07] WARNING[1684] channel.c: Hangup failed!  Strange things
may happen!
[Oct 12 11:26:07] WARNING[1684] channel.c: Failed to perform masquerade
[Oct 12 11:26:07] WARNING[1684] channel.c: Channel
'Local/1127-0004132c4403-1 at DialLine-3d9b;1' may not have been hung up
properly

The bug happens several times a day.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015349 Deadlock in do_monitor() of chan_sip
related to          0017363 [patch] Redirecting ;1 side of local ch...
====================================================================== 

---------------------------------------------------------------------- 
 (0127162) svnbot (reporter) - 2010-09-20 18:16
 https://issues.asterisk.org/view.php?id=16057#c127162 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 287685

U   branches/1.6.2/main/channel.c

------------------------------------------------------------------------
r287685 | alecdavis | 2010-09-20 18:16:45 -0500 (Mon, 20 Sep 2010) | 18
lines

ast_channel_masquerade: Avoid recursive masquerades.

Check all 4 combinations of (original/clonechan) * (masq/masqr).

Initially original->masq and clonechan->masqr were only checked.

It's possible with multiple masq's planned - and not yet executed, that
 the 'original' chan could already have another masq'd into it - thus
original->masqr
would be set, that masqr would lost.
Likewise for the clonechan->masq.

(closes issue
https://issues.asterisk.org/view.php?id=16057;https://issues.asterisk.org/view.php?id=17363)
Reported by: amorsen;davidw,alecdavis
Patches: 
      based on bug16057.diff4.txt uploaded by alecdavis (license 585)
Tested by: ramonpeek, davidw, alecdavis


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=287685 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-20 18:16 svnbot         Checkin                                      
2010-09-20 18:16 svnbot         Note Added: 0127162                          
======================================================================