[asterisk-bugs] [Asterisk 0017928]: [patch] AST_MAX_EXTENSION limitation on hint string length

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17928 
====================================================================== 
Reported By:                mdu113
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17928
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-2135 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 283960 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-08-30 09:42 CDT
Last Modified:              2010-09-16 15:08 CDT
====================================================================== 
Summary:                    [patch] AST_MAX_EXTENSION limitation on hint string
length
Description: 
This is basically a reopening of issue 13945 as suggested by tilghman,
inspired by commit in r263637 that was closing issue 17257. 
The problem with long hint strings has always existed in asterisk 1.4, but
since r263637 says "Remove arbitrary size limitation for hints", I thought
I'd bring it back to developers attention.
Here's the problem as it looks now:
Devices that fit into AST_MAX_EXTENSION in hint string work perfectly with
immediate reaction to state changes.
Devices that don't fit into AST_MAX_EXTENSION seems to also work. Kind of.
There's a long (something like 30-60 seconds) delay between device state
changes (I place a call on monitored device) and asterisk actually notices
it. 
Here's an example. 
I create a hint that monitors, let's say, 10 devices with hint string
length definitely > 80 characters. If I call device listed first in the
hint string (it fully fits into AST_MAX_EXTENSION characters) then asterisk
notices it right away and hint state changes immediately. 
Contrary, if I call device listed last in the hint strings (doesn't fit
into AST_MAX_EXTENSION characters) then there will be a long delay before
asterisk will notice it.
It looks like devices that appeared too far in the hints string aren't
being watched by the standard mechanism, which is probably events-based,
but there's some background process that rechecks all the state of all
devices periodically (and not very often) and that one catches it.
It would be very nice if that can be fixed (or at least delay to be
decreased) as it's very common for us to monitor multiple devices on a
single hint.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017257 [patch] Long hints make asterisk crash
has duplicate       0013945 Asterisk can't watch for more than 5 de...
====================================================================== 

---------------------------------------------------------------------- 
 (0127062) svnbot (reporter) - 2010-09-16 15:08
 https://issues.asterisk.org/view.php?id=17928#c127062 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 287121

_U  trunk/
U   trunk/main/pbx.c

------------------------------------------------------------------------
r287121 | mnicholson | 2010-09-16 15:08:51 -0500 (Thu, 16 Sep 2010) | 29
lines

Merged revisions 287120 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r287120 | mnicholson | 2010-09-16 15:07:38 -0500 (Thu, 16 Sep 2010) | 22
lines
  
  Merged revisions 287119 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2
  
  ................
    r287119 | mnicholson | 2010-09-16 15:06:16 -0500 (Thu, 16 Sep 2010) |
15 lines
    
    Merged revisions 287118 via svnmerge from 
    https://origsvn.digium.com/svn/asterisk/branches/1.4
    
    ........
      r287118 | mnicholson | 2010-09-16 15:04:46 -0500 (Thu, 16 Sep 2010)
| 8 lines
      
      Don't limit hint processing in ast_hint_state_changed() to
AST_MAX_EXTENSION length strings.
      
      (closes issue https://issues.asterisk.org/view.php?id=17928)
      Reported by: mdu113
      Patches:
            20100831__issue17928.diff.txt uploaded by tilghman (license
14)
      Tested by: mdu113
    ........
  ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=287121 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-16 15:08 svnbot         Checkin                                      
2010-09-16 15:08 svnbot         Note Added: 0127062                          
======================================================================