[asterisk-bugs] [Asterisk 0017877]: [patch] Merging events for Exchange web service doesn't work as expected, resulting in only one event in calendar

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17877 
====================================================================== 
Reported By:                pitel
Assigned To:                twilson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17877
Category:                   Resources/res_calendar
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     ready for review
Target Version:             1.8.0
Asterisk Version:           SVN 
JIRA:                       SWP-2063 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/916 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 282538 
Request Review:              
====================================================================== 
Date Submitted:             2010-08-17 07:14 CDT
Last Modified:              2010-09-14 01:55 CDT
====================================================================== 
Summary:                    [patch] Merging events for Exchange web service
doesn't work as expected, resulting in only one event in calendar
Description: 
I just noticed that when I have multiple events in EWS calendar, only one
is merged. And I found a strange behaviour of ast_calendar_merge_events().

I added a little debug output (in attached patch) and get this result:

--
AQAPAHRlc3RmaXRAaXBleC5jegBGAAADyTdZ3ABu8EOjYAFhV6KsHgcA+GG41xCdl025mKVi8islNgAAAx0AAABc2kyxph+ESpyNgxlJiF/xAAABHppPAAAA:
AAA
++
AAAPAHRlc3RmaXRAaXBleC5jegFRAAgIzQu2RRQAAEYAAAAAyTdZ3ABu8EOjYAFhV6KsHgcA+GG41xCdl025mKVi8islNgAAAAAAHQAAdAXzuHYsTEahylQnDZcWqAAPO7o49gAAEA==:
BBB
--
AAAPAHRlc3RmaXRAaXBleC5jegFRAAgIzQu2RRQAAEYAAAAAyTdZ3ABu8EOjYAFhV6KsHgcA+GG41xCdl025mKVi8islNgAAAAAAHQAAdAXzuHYsTEahylQnDZcWqAAPO7o49gAAEA==:
BBB
++
AQAPAHRlc3RmaXRAaXBleC5jegBGAAADyTdZ3ABu8EOjYAFhV6KsHgcA+GG41xCdl025mKVi8islNgAAAx0AAABc2kyxph+ESpyNgxlJiF/xAAABHppPAAAA:
AAA

-- in beggining of line means the event is removed from our internal
calendat, ++ means it was added and there should be also == which means it
was merged. Every action follows by UID of event, colon and name of event.

As you can, the event AAA is removed, event BBB is added, then removed and
then is event AAA added again, resulting in only event AAA being in
internal calendar.

I really don't know why is this happening, since UID is compared with
known events, and then is decided if we know if this event already exist or
not. And appereantly, the UIDs match, so I have really no idea why it
results in removing and adding the same event instead of merging.

And just for infomration, icalendar modul works as expected, merging
already known events.
====================================================================== 

---------------------------------------------------------------------- 
 (0126915) svnbot (reporter) - 2010-09-14 01:55
 https://issues.asterisk.org/view.php?id=17877#c126915 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 286617

U   branches/1.8/res/res_calendar_ews.c

------------------------------------------------------------------------
r286617 | pitel | 2010-09-14 01:55:44 -0500 (Tue, 14 Sep 2010) | 7 lines

Merging events for Exchange web service doesn't work as expected,
resulting in only one event in calendar

The solution is to use "global" counter of events, since we do new
requests for every event and calendar sync after every request. So now we
do sync only after last request.

(closes issue https://issues.asterisk.org/view.php?id=17877)
Review: https://reviewboard.asterisk.org/r/916/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=286617 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-14 01:55 svnbot         Note Added: 0126915                          
======================================================================