[asterisk-bugs] [Asterisk 0017947]: [patch] Allow user more control over parked calls that expire from a one touch park

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17947 
====================================================================== 
Reported By:                bluecrow76
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17947
Category:                   Features/Parking
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                       SWP-2164 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-09-02 17:51 CDT
Last Modified:              2010-09-09 17:10 CDT
====================================================================== 
Summary:                    [patch] Allow user more control over parked calls
that expire from a one touch park
Description: 
This patch allows the user more control of calls that expire after being
parked using one touch parking.

The current behavior of a call expiring after being one touch parked is to
create an extension in a context that dials the device that parked the call
for 30 seconds with appropriate dial arguments.  After that 30 seconds
expires, the call terminates because there is no more dial plan for
asterisk to process.

This patch can be applied against 1.6.2.11, the current beta of 1.8 and
trunk.

I am running this in production on 1.6.2.5, 1.6.2.9 and 1.6.2.11, along
with my other patches to parking (0017946).

====================================================================== 

---------------------------------------------------------------------- 
 (0126796) bluecrow76 (reporter) - 2010-09-09 17:10
 https://issues.asterisk.org/view.php?id=17947#c126796 
---------------------------------------------------------------------- 
It looks like I completely missed that.  I developed this code to fill a
need in the 1.6.2 code base for a customer and then submitted the patch
against trunk.  It looks like I developed very similar functionality.  It
was fun though!  :-)

The only thing that I can see that comebacktocustom does different is
this.  comebacktoorigin sends all calls to the same context,
parkedcallstimeout.  comebacktocustom sends calls to the parking lot
context at s,1.  I live in a multitenant world, so some tenants will want
to handle timed out calls differently (some want a particular callerid,
some a particular ring tone, some both).

I could emulate that behavior by setting a channel variable that tells me
where to jump out of parkedcallstimeout to handle things differently per
customer.

I also added two channel variables when the call times out, PARKER and
PARKINGSLOT.  PARKER is the device that originally parked the call so the
dialplan can know who to call back.  Technically, that was not previously
available to the dialplan unless you took the flat extension and tried to
tweak it back to a channel name.  PARKINGSLOT was previously only set if
comebacktoorigin was set to no.

So it looks like comebacktocustom just allows the user using multiple
parking lots more flexibility in that the timeout context can be custom per
parking lot, plus a few other options.

Thoughts? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-09 17:10 bluecrow76     Note Added: 0126796                          
======================================================================